Summary: | Add classes to Shibboleth text on OPAC login page | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | OPAC | Assignee: | Aleisha Amohia <aleisha> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | Sponsored | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
23.11.00,23.05.06,22.11.12
|
Circulation function: | |
Bug Depends on: | |||
Bug Blocks: | 36141 | ||
Attachments: |
Bug 35147: Add IDs to Shibboleth text on OPAC login page
Bug 35147: Add classes to Shibboleth text on OPAC login page Bug 35147: Add classes to Shibboleth text on OPAC login page Bug 35147: Add classes to Shibboleth text on OPAC login page Bug 35147: (QA follow-up) Capitalzation: Shibboleth Login |
Description
Aleisha Amohia
2023-10-25 00:37:14 UTC
Created attachment 157769 [details] [review] Bug 35147: Add IDs to Shibboleth text on OPAC login page This enhancement makes it easier for libraries to change the Shibboleth-related messages on the OPAC login page. Libraries can employ OPACUserJS to change the text. For e.g., I can replace the message "If you do not have a Shibboleth account, but you do have a local login, then you may login below." by putting the following in OPACUserJS: $("#shib-local-text").text("If you do not have a staff member account, but are a member of the library, then you may log in below."); To test: 1. Go to <your-opac-url>/cgi-bin/koha/opac-user.pl , or disable the OpacPublic system preference. Ensure you are logged out of the OPAC. 2. In the staff interface, search for the OPACUserJS system preference under Koha Administration. Add the following JS and Save: $("#shib-invalid").text("Test changing the invalid Shibboleth login message."); $("#shib-title").text("Test changing the Shibboleth login heading."); $("#shib-link-text").text("Test changing the Shibboleth account link text."); $("#shib-local-title").text("Test changing the local login heading."); $("#shib-local-text").text("Test changing the message that shows if you do not have a Shibboleth account."); 3. Refresh the OPAC and confirm the text changes to reflect your JS. Note: The invalid Shibboleth login will be a bit harder to test, so if you can't test, confirm the HTML in the patch looks correct. Sponsored-by: New Zealand Council for Educational Research Created attachment 157770 [details] [review] Bug 35147: Add classes to Shibboleth text on OPAC login page This enhancement makes it easier for libraries to change the Shibboleth-related messages on the OPAC login page. Libraries can employ OPACUserJS to change the text. For e.g., I can replace the message "If you do not have a Shibboleth account, but you do have a local login, then you may login below." by putting the following in OPACUserJS: $(".shib_local_text").text("If you do not have a staff member account, but are a member of the library, then you may log in below."); To test: 1. Go to <your-opac-url>/cgi-bin/koha/opac-user.pl , or disable the OpacPublic system preference. Ensure you are logged out of the OPAC. 2. In the staff interface, search for the OPACUserJS system preference under Koha Administration. Add the following JS and Save: $(".shib_invalid").text("Test changing the invalid Shibboleth login message."); $(".shib_title").text("Test changing the Shibboleth login heading."); $(".shib_url").text("Test changing the Shibboleth account link text."); $(".shib_local_title").text("Test changing the local login heading."); $(".shib_local_text").text("Test changing the message that shows if you do not have a Shibboleth account."); 3. Refresh the OPAC and confirm the text changes to reflect your JS. Note: The invalid Shibboleth login will be a bit harder to test, so if you can't test, confirm the HTML in the patch looks correct. Sponsored-by: New Zealand Council for Educational Research Forgot to include on the test plan - click on the Log in button in the top masthead bar and confirm the text there has also been updated. Created attachment 157859 [details] [review] Bug 35147: Add classes to Shibboleth text on OPAC login page This enhancement makes it easier for libraries to change the Shibboleth-related messages on the OPAC login page. Libraries can employ OPACUserJS to change the text. For e.g., I can replace the message "If you do not have a Shibboleth account, but you do have a local login, then you may login below." by putting the following in OPACUserJS: $(".shib_local_text").text("If you do not have a staff member account, but are a member of the library, then you may log in below."); To test: 1. Go to <your-opac-url>/cgi-bin/koha/opac-user.pl , or disable the OpacPublic system preference. Ensure you are logged out of the OPAC. 2. In the staff interface, search for the OPACUserJS system preference under Koha Administration. Add the following JS and Save: $(".shib_invalid").text("Test changing the invalid Shibboleth login message."); $(".shib_title").text("Test changing the Shibboleth login heading."); $(".shib_url").text("Test changing the Shibboleth account link text."); $(".shib_local_title").text("Test changing the local login heading."); $(".shib_local_text").text("Test changing the message that shows if you do not have a Shibboleth account."); 3. Refresh the OPAC and confirm the text changes to reflect your JS. Note: The invalid Shibboleth login will be a bit harder to test, so if you can't test, confirm the HTML in the patch looks correct. Sponsored-by: New Zealand Council for Educational Research Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 158018 [details] [review] Bug 35147: Add classes to Shibboleth text on OPAC login page This enhancement makes it easier for libraries to change the Shibboleth-related messages on the OPAC login page. Libraries can employ OPACUserJS to change the text. For e.g., I can replace the message "If you do not have a Shibboleth account, but you do have a local login, then you may login below." by putting the following in OPACUserJS: $(".shib_local_text").text("If you do not have a staff member account, but are a member of the library, then you may log in below."); To test: 1. Go to <your-opac-url>/cgi-bin/koha/opac-user.pl , or disable the OpacPublic system preference. Ensure you are logged out of the OPAC. 2. In the staff interface, search for the OPACUserJS system preference under Koha Administration. Add the following JS and Save: $(".shib_invalid").text("Test changing the invalid Shibboleth login message."); $(".shib_title").text("Test changing the Shibboleth login heading."); $(".shib_url").text("Test changing the Shibboleth account link text."); $(".shib_local_title").text("Test changing the local login heading."); $(".shib_local_text").text("Test changing the message that shows if you do not have a Shibboleth account."); 3. Refresh the OPAC and confirm the text changes to reflect your JS. Note: The invalid Shibboleth login will be a bit harder to test, so if you can't test, confirm the HTML in the patch looks correct. Sponsored-by: New Zealand Council for Educational Research Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 158019 [details] [review] Bug 35147: (QA follow-up) Capitalzation: Shibboleth Login Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Small very useful enhancement, I backport. Pushed to 23.05.x for 23.05.06 Nice work everyone! Pushed to oldstable for 22.11.x |