Bug 35173

Summary: Call concat correctly for EDI SFTP Transport errors
Product: Koha Reporter: Martin Renvoize (ashimema) <martin.renvoize>
Component: Architecture, internals, and plumbingAssignee: Martin Renvoize (ashimema) <martin.renvoize>
Status: CLOSED FIXED QA Contact: Kyle M Hall (khall) <kyle>
Severity: minor    
Priority: P5 - low CC: fridolin.somers
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.06,22.11.12
Circulation function:
Attachments: Bug 35173: Correctly concat error strings
Bug 35173: Correctly concat error strings

Description Martin Renvoize (ashimema) 2023-10-27 10:45:02 UTC
We are doing internal string concat within the EDI Transport module which results in 'Net::SFTP::Foreign=HASH(0x559c9118f0c8)->error' as apposed to the actual errors in the logs.
Comment 1 Martin Renvoize (ashimema) 2023-10-27 10:49:52 UTC
Created attachment 157978 [details] [review]
Bug 35173: Correctly concat error strings

This patch moves the call to $sftp->error outside of the double quote
string and into a . concat to properly expose the error message as
apposed to outputting 'Net::SFTP::Foreign=HASH(0x559c9118f0c8)->error'

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 2 Kyle M Hall (khall) 2023-10-27 12:04:24 UTC
Created attachment 157980 [details] [review]
Bug 35173: Correctly concat error strings

This patch moves the call to $sftp->error outside of the double quote
string and into a . concat to properly expose the error message as
apposed to outputting 'Net::SFTP::Foreign=HASH(0x559c9118f0c8)->error'

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 3 Tomás Cohen Arazi (tcohen) 2023-10-27 19:55:09 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 4 Fridolin Somers 2023-11-08 08:01:48 UTC
Pushed to 23.05.x for 23.05.06
Comment 5 Matt Blenkinsop 2023-11-13 15:23:34 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x