| Summary: | force_checkout permission can override all blocks on a patron account but only shows when they are restricted | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Circulation | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | crose, fridolin.somers, gmcharlt, kyle.m.hall, martin.renvoize, victor |
| Version: | Main | Keywords: | Sandbox |
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37703 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 643 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 35188: Show checkout override for all noisseus statuses
Bug 35188: Show checkout override for all noisseus statuses Bug 35188: Show checkout override for all noisseus statuses Bug 35188: [23.05.x] Show checkout override for all noissues statuses |
||
|
Description
Nick Clemens (kidclamp)
2023-10-30 12:45:06 UTC
Created attachment 158062 [details] [review] Bug 35188: Show checkout override for all noisseus statuses This patch moves the override button up one level into the list of noissues in order to allow overriding any blocking status To test: 1 - Log in to Koha with a user with force_checkout permission (superlibrarian ok too) 2 - Mark a patron as expired, lost card, gone no address 3 - Go to 'Check out' page for the patorn 4 - Note you cannot override the restrictions 5 - Add a manual restriction/debarment 6 - Go to checkout again, now you can override 7 - Remove the debarment 8 - Add manually ot URL of checkout page '&foreallow=1' 9 - Note you can now override the other restrictions 10 - Apply patch 11 - Reload patron 12 - Note you now see the override button on the check out screen 13 - Add a debarment 14 - Confirm the button is still there 15 - Confirm overriding allows the checkout (with or without a debarment) *** Bug 34588 has been marked as a duplicate of this bug. *** Created attachment 158271 [details] [review] Bug 35188: Show checkout override for all noisseus statuses This patch moves the override button up one level into the list of noissues in order to allow overriding any blocking status To test: 1 - Log in to Koha with a user with force_checkout permission (superlibrarian ok too) 2 - Mark a patron as expired, lost card, gone no address 3 - Go to 'Check out' page for the patorn 4 - Note you cannot override the restrictions 5 - Add a manual restriction/debarment 6 - Go to checkout again, now you can override 7 - Remove the debarment 8 - Add manually ot URL of checkout page '&foreallow=1' 9 - Note you can now override the other restrictions 10 - Apply patch 11 - Reload patron 12 - Note you now see the override button on the check out screen 13 - Add a debarment 14 - Confirm the button is still there 15 - Confirm overriding allows the checkout (with or without a debarment) Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Created attachment 158413 [details] [review] Bug 35188: Show checkout override for all noisseus statuses This patch moves the override button up one level into the list of noissues in order to allow overriding any blocking status To test: 1 - Log in to Koha with a user with force_checkout permission (superlibrarian ok too) 2 - Mark a patron as expired, lost card, gone no address 3 - Go to 'Check out' page for the patorn 4 - Note you cannot override the restrictions 5 - Add a manual restriction/debarment 6 - Go to checkout again, now you can override 7 - Remove the debarment 8 - Add manually ot URL of checkout page '&foreallow=1' 9 - Note you can now override the other restrictions 10 - Apply patch 11 - Reload patron 12 - Note you now see the override button on the check out screen 13 - Add a debarment 14 - Confirm the button is still there 15 - Confirm overriding allows the checkout (with or without a debarment) Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Works, makes sense, QA script happy, code looks good, passing QA :) Pushed to master for 23.11. Nice work everyone, thanks! Does not apply on 23.05.x Please provide rebased patch Created attachment 158803 [details] [review] Bug 35188: [23.05.x] Show checkout override for all noissues statuses This patch moves the override button up one level into the list of noissues in order to allow overriding any blocking status To test: 1 - Log in to Koha with a user with force_checkout permission (superlibrarian ok too) 2 - Mark a patron as expired, lost card, gone no address 3 - Go to 'Check out' page for the patorn 4 - Note you cannot override the restrictions 5 - Add a manual restriction/debarment 6 - Go to checkout again, now you can override 7 - Remove the debarment 8 - Add manually ot URL of checkout page '&foreallow=1' 9 - Note you can now override the other restrictions 10 - Apply patch 11 - Reload patron 12 - Note you now see the override button on the check out screen 13 - Add a debarment 14 - Confirm the button is still there 15 - Confirm overriding allows the checkout (with or without a debarment) Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> |