Bug 35212

Summary: Correct mismatched label on identity provider entry form
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: trivial    
Priority: P5 - low CC: andrew.auld, fridolin.somers
Version: MainKeywords: Sandbox
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.06,22.11.12
Circulation function:
Attachments: Bug 35212: Correct mismatched label on identity provider entry form
Bug 35212: Correct mismatched label on identity provider entry form
Bug 35212: Correct mismatched label on identity provider entry form

Description Owen Leonard 2023-11-01 10:21:18 UTC
The identity provider entry form  has a mismatched label: The label for the "Allow staff" field points to the "Allow OPAC" field.
Comment 1 Owen Leonard 2023-11-01 10:26:32 UTC
Created attachment 158167 [details] [review]
Bug 35212: Correct mismatched label on identity provider entry form

This patch corrects the identity provider form so that the label for the
"Allow staff" field has the correct "for" attribute. Currently it is a
duplicate of the one for the "Allow OPAC" field.

To test, apply the patch and go to Administration -> Identity providers.

- Click "New identity provider"
- Near the bottom of the form, look for the "Allow staff" field.
- Clicking the "Allow staff" label should activate the corresponding
  dropdown.
Comment 2 David Nind 2023-11-01 23:35:21 UTC
Created attachment 158228 [details] [review]
Bug 35212: Correct mismatched label on identity provider entry form

This patch corrects the identity provider form so that the label for the
"Allow staff" field has the correct "for" attribute. Currently it is a
duplicate of the one for the "Allow OPAC" field.

To test, apply the patch and go to Administration -> Identity providers.

- Click "New identity provider"
- Near the bottom of the form, look for the "Allow staff" field.
- Clicking the "Allow staff" label should activate the corresponding
  dropdown.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2023-11-04 17:51:57 UTC
Created attachment 158392 [details] [review]
Bug 35212: Correct mismatched label on identity provider entry form

This patch corrects the identity provider form so that the label for the
"Allow staff" field has the correct "for" attribute. Currently it is a
duplicate of the one for the "Allow OPAC" field.

To test, apply the patch and go to Administration -> Identity providers.

- Click "New identity provider"
- Near the bottom of the form, look for the "Allow staff" field.
- Clicking the "Allow staff" label should activate the corresponding
  dropdown.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-11-06 11:40:48 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-11-10 07:25:03 UTC
Pushed to 23.05.x for 23.05.06
Comment 6 Pedro Amorim 2023-11-14 14:50:28 UTC
Nice work everyone!

Pushed to 22.11.x for next release