| Summary: | Make a few assumptions more explicit in Suggestions.t | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Test Suite | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, pedro.amorim |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: |
23.11.00,23.05.06
|
Circulation function: | |
| Attachments: |
Bug 35215: Add few assumptions in Suggestions.t around emailing
Bug 35215: Add few assumptions in Suggestions.t around emailing |
||
|
Description
Marcel de Rooy
2023-11-01 15:14:58 UTC
Created attachment 158177 [details] [review] Bug 35215: Add few assumptions in Suggestions.t around emailing Test plan: Without this patch, set pref ReplytoDefault or EmailAddressForSuggestions. Run t/db_dependent/Suggestions.t (FAIL) Fill branch email and reply for CPL branch. Run t/db_dependent/Suggestions.t (FAIL: more errors) Apply patch. Run t/db_dependent/Suggestions.t (PASS) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Trivial change in unit test: self SO. Created attachment 158393 [details] [review] Bug 35215: Add few assumptions in Suggestions.t around emailing Test plan: Without this patch, set pref ReplytoDefault or EmailAddressForSuggestions. Run t/db_dependent/Suggestions.t (FAIL) Fill branch email and reply for CPL branch. Run t/db_dependent/Suggestions.t (FAIL: more errors) Apply patch. Run t/db_dependent/Suggestions.t (PASS) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.06 |