Summary: | Duplicate ids in markup of patron card layout edit form | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Courtney Brown <courtneybrown> |
Status: | Failed QA --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | minor | ||
Priority: | P5 - low | CC: | courtneybrown, jonathan.druart, m.de.rooy, testopia |
Version: | Main | Keywords: | Academy, accessibility |
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
BUG: 35237 Duplicate ids in markup of patron card form updated to have unique IDs.
Bug 35237: Give patron card layout form elements unique IDs Bug 35237: Give patron card layout form elements unique IDs |
Description
Owen Leonard
2023-11-02 17:56:26 UTC
Created attachment 184253 [details] [review] BUG: 35237 Duplicate ids in markup of patron card form updated to have unique IDs. Test plan: 1. Head to 'tool's then 'patronn card creator' 2. Click on 'Layouts' underneath 'Manage' 3. Click on 'Edit' 4. Inspect the page and check that the ids for Page side are unique. Created attachment 184421 [details] [review] Bug 35237: Give patron card layout form elements unique IDs This patch ensures the following patron card layout form fields use unique IDs: - page side - guide box - guide grid This semantically links the options to their labels so is more accessible for screen readers and keyboard navigation. The patch also adds a 'default' option to the original labels so they can become useful elements on the form rather than just text labels. Test plan: 1. Head to 'tools' then 'patron card creator' 2. Click on 'Layouts' underneath 'Manage' 3. Click on 'Edit' 4. Confirm it's easy to tell which options are available and chosen for page side, guide box, and guide grid 5. Click on the text labels for the options i.e. front, back, on, off. Confirm the relevant radio button is selected Sponsored-by: Catalyst IT Created attachment 186246 [details] [review] Bug 35237: Give patron card layout form elements unique IDs This patch ensures the following patron card layout form fields use unique IDs: - page side - guide box - guide grid This semantically links the options to their labels so is more accessible for screen readers and keyboard navigation. The patch also adds a 'default' option to the original labels so they can become useful elements on the form rather than just text labels. Test plan: 1. Head to 'tools' then 'patron card creator' 2. Click on 'Layouts' underneath 'Manage' 3. Click on 'Edit' 4. Confirm it's easy to tell which options are available and chosen for page side, guide box, and guide grid 5. Click on the text labels for the options i.e. front, back, on, off. Confirm the relevant radio button is selected Sponsored-by: Catalyst IT Signed-off-by: noah <noah@inlibro.com> Owen, can you confirm it's the our preferred styling for radio buttons? Before: https://snipboard.io/CgRw6D.jpg After: https://snipboard.io/josfAn.jpg I don't think the label's values should be bold. - <label for="page_side">Page side: </label> + <label for="page_side_front">Page side: </label> Not sure about this change. Why front here? + <label for="page_side_front">Front: <input type="radio" name="page_side" id="page_side_front" value="F" /></label> Why include the input in the label ? Please explain. |