| Summary: | Markup errors in point of sale template | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 35241: Fix markup errors in point of sale template
Bug 35241: Fix markup errors in point of sale template Bug 35241: Fix markup errors in point of sale template |
||
|
Description
Owen Leonard
2023-11-02 18:35:00 UTC
Created attachment 158280 [details] [review] Bug 35241: Fix markup errors in point of sale template This patch makes several markup corrections to the Point of Sale page, fixing duplicate ids, invalid "selected" attributes*, a broken comment tag, and an invalid "href" attribute. * The "selected" attribute in this template is on a disabled <option>, so it can't be selected. The patch also changes <div class="action"> to <fieldset class="action"> for consistency and better layout. It makes some changes to the "Payment received" dialog in order to improve visual consistency. To test, apply the patch and make sure the EnablePointOfSale preference is turned on. - Go to Point of Sale. - Test the process of adding items for purchase and collecting payment. - After you submit the payment the confirmation dialog should look correct, and the "Print" and "Email" buttons should both work correctly. Created attachment 158285 [details] [review] Bug 35241: Fix markup errors in point of sale template This patch makes several markup corrections to the Point of Sale page, fixing duplicate ids, invalid "selected" attributes*, a broken comment tag, and an invalid "href" attribute. * The "selected" attribute in this template is on a disabled <option>, so it can't be selected. The patch also changes <div class="action"> to <fieldset class="action"> for consistency and better layout. It makes some changes to the "Payment received" dialog in order to improve visual consistency. To test, apply the patch and make sure the EnablePointOfSale preference is turned on. - Go to Point of Sale. - Test the process of adding items for purchase and collecting payment. - After you submit the payment the confirmation dialog should look correct, and the "Print" and "Email" buttons should both work correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 158394 [details] [review] Bug 35241: Fix markup errors in point of sale template This patch makes several markup corrections to the Point of Sale page, fixing duplicate ids, invalid "selected" attributes*, a broken comment tag, and an invalid "href" attribute. * The "selected" attribute in this template is on a disabled <option>, so it can't be selected. The patch also changes <div class="action"> to <fieldset class="action"> for consistency and better layout. It makes some changes to the "Payment received" dialog in order to improve visual consistency. To test, apply the patch and make sure the EnablePointOfSale preference is turned on. - Go to Point of Sale. - Test the process of adding items for purchase and collecting payment. - After you submit the payment the confirmation dialog should look correct, and the "Print" and "Email" buttons should both work correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Does not apply on 23.05.x |