Bug 35247

Summary: Add new route to simply list old reserves by patron id
Product: Koha Reporter: Thibaud Guillot (thibaud_g) <thibaud.guillot>
Component: REST APIAssignee: Thibaud Guillot (thibaud_g) <thibaud.guillot>
Status: RESOLVED DUPLICATE QA Contact:
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, jonathan.druart, tomascohen
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35353
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 35247: Add new API route to list old reserves by patron
Bug 35247: Add new API route to list old reserves by patron
Bug 35247: (follow-up) Perltidy fixes to OldHolds.pm

Description Thibaud Guillot (thibaud_g) 2023-11-03 11:12:18 UTC
Hi everyone,

I purpose to add a new endpoint to list all old reserves by patron id. The definition is the same than "hold" definition and it just a new route to display old reserve for see cancellation reason or cancellation date for example.
Comment 1 Thibaud Guillot (thibaud_g) 2023-11-03 11:15:00 UTC
Created attachment 158325 [details] [review]
Bug 35247: Add new API route to list old reserves by patron

Test plan:

1) Apply this patch
2) Go to "/api/v1/patrons/{patron_id}/old_holds" to see old reserves by
   patron
Comment 2 Owen Leonard 2023-11-03 11:41:26 UTC
Created attachment 158326 [details] [review]
Bug 35247: Add new API route to list old reserves by patron

Test plan:

1) Apply this patch
2) Go to "/api/v1/patrons/{patron_id}/old_holds" to see old reserves by
   patron

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Owen Leonard 2023-11-03 11:41:28 UTC
Created attachment 158327 [details] [review]
Bug 35247: (follow-up) Perltidy fixes to OldHolds.pm

Whitespace changes only.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Thibaud Guillot (thibaud_g) 2023-11-03 14:40:49 UTC
Thanks Owen :)
Comment 5 Jonathan Druart 2024-01-26 08:17:17 UTC
Please see bug 35353 comment 5.

We have now 3 implementations for the same thing...
Comment 6 Fridolin Somers 2024-11-13 10:50:35 UTC
Bug 35353 is now pushed so close as duplicate ?
Comment 7 Thibaud Guillot (thibaud_g) 2024-11-13 10:55:36 UTC

*** This bug has been marked as a duplicate of bug 35353 ***