Bug 35249

Summary: Use DataTables RowReorder extension instead of tableDND jQuery plugin
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: Needs documenting --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, jonathan.druart
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00
Circulation function:
Bug Depends on: 34913    
Bug Blocks: 35138    
Attachments: Bug 35249: Use DataTables RowReorder extension instead of tableDND jQuery plugin
Bug 35249: Adjust table id and style
Bug 35249: Remove tableDnD from the about page
Bug 35249: Remove sort indicator on th
Bug 35249: Use DataTables RowReorder extension instead of tableDND jQuery plugin
Bug 35249: Adjust table id and style
Bug 35249: Remove tableDnD from the about page
Bug 35249: Remove sort indicator on th

Description Owen Leonard 2023-11-03 14:32:31 UTC
I think it makes sense to replace jquery.tablednd.js with DataTables "official" extension RowReorder:

https://datatables.net/extensions/rowreorder/
Comment 1 Jonathan Druart 2024-03-21 11:27:32 UTC
Created attachment 163598 [details] [review]
Bug 35249: Use DataTables RowReorder extension instead of tableDND jQuery plugin

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 2 Jonathan Druart 2024-03-21 11:27:34 UTC
Created attachment 163599 [details] [review]
Bug 35249: Adjust table id and style

We could eventually have a table for authorities, so better to have a
specific table id.

Also I think it's better to have the table smaller than taking the whole
width

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Jonathan Druart 2024-03-21 11:27:37 UTC
Created attachment 163600 [details] [review]
Bug 35249: Remove tableDnD from the about page

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2024-03-21 11:28:31 UTC
Talked with Owen and we wrote more or less the same patch (his was working however! Mine was missing the hidden column which didn't make the reorder works correctly).
Comment 5 Jonathan Druart 2024-03-21 11:39:31 UTC
Created attachment 163601 [details] [review]
Bug 35249: Remove sort indicator on th
Comment 6 Nick Clemens (kidclamp) 2024-04-12 07:48:02 UTC
Created attachment 164795 [details] [review]
Bug 35249: Use DataTables RowReorder extension instead of tableDND jQuery plugin

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 7 Nick Clemens (kidclamp) 2024-04-12 07:48:05 UTC
Created attachment 164796 [details] [review]
Bug 35249: Adjust table id and style

We could eventually have a table for authorities, so better to have a
specific table id.

Also I think it's better to have the table smaller than taking the whole
width

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 8 Nick Clemens (kidclamp) 2024-04-12 07:48:07 UTC
Created attachment 164797 [details] [review]
Bug 35249: Remove tableDnD from the about page

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 9 Nick Clemens (kidclamp) 2024-04-12 07:48:09 UTC
Created attachment 164798 [details] [review]
Bug 35249: Remove sort indicator on th

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 10 Katrin Fischer 2024-04-26 17:33:17 UTC
Fixed a conflict in the about page and followed-up on a QA script failure:

 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt
   FAIL	  forbidden patterns
		forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 12)
		forbidden pattern: Do *not* include full path to css files, use the Asset TT plugin (bug 20538) (line 12)
Comment 11 Katrin Fischer 2024-04-26 18:19:34 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 12 Fridolin Somers 2024-05-24 08:57:05 UTC
Not backported to 23.11.x