| Summary: | Adding files to basket from a staged file uses wrong inputs for order information when not all records are selected | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Acquisitions | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, f.demians, fridolin.somers, pedro.amorim, victor |
| Version: | Main | Keywords: | rel_22_11_candidate |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.06,22.11.13
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 35823 | ||
| Attachments: |
Bug 35254: Add import_record_id to order inputs
Bug 35254: Add import_record_id to order inputs Bug 35254: Add import_record_id to order inputs Bug 35254: [22.11.x] Add import_record_id to order inputs |
||
|
Description
Nick Clemens (kidclamp)
2023-11-03 17:56:36 UTC
Created attachment 158366 [details] [review] Bug 35254: Add import_record_id to order inputs This patch follows the logic of bug 32166 and adds specific inputs for each order to avoid any misalignment when some records are not imported To test: 1 - Find a vendor in acquisitions 2 - Create or find an open basket 3 - Add to basket form a new file 4 - Stage file and add to basket 5 - Select the second record in the list 6 - Enter price info 7 - Save (don't forget, you need to set item type in the second tab) 8 - The order has no price info! 9 - Apply patch 10 - Repeat 3-7 above, staging file fresh 11 - Confirm order has correct prices 12 - Test with a file with many records 13 - Confirm any combination of choosing/skipping records works as expected Created attachment 158374 [details] [review] Bug 35254: Add import_record_id to order inputs This patch follows the logic of bug 32166 and adds specific inputs for each order to avoid any misalignment when some records are not imported To test: 1 - Find a vendor in acquisitions 2 - Create or find an open basket 3 - Add to basket form a new file 4 - Stage file and add to basket 5 - Select the second record in the list 6 - Enter price info 7 - Save (don't forget, you need to set item type in the second tab) 8 - The order has no price info! 9 - Apply patch 10 - Repeat 3-7 above, staging file fresh 11 - Confirm order has correct prices 12 - Test with a file with many records 13 - Confirm any combination of choosing/skipping records works as expected Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I really wonder why we didn't stumble on this much sooner? CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt Auto-merging acqui/addorderiso2709.pl CONFLICT (content): Merge conflict in acqui/addorderiso2709.pl Not trivial for addorderiso2709.tt My bad, was trying to apply bug 32166 which is why I wasn't finding the last commit were it applies well. Continuing review. Created attachment 158565 [details] [review] Bug 35254: Add import_record_id to order inputs This patch follows the logic of bug 32166 and adds specific inputs for each order to avoid any misalignment when some records are not imported To test: 1 - Find a vendor in acquisitions 2 - Create or find an open basket 3 - Add to basket form a new file 4 - Stage file and add to basket 5 - Select the second record in the list 6 - Enter price info 7 - Save (don't forget, you need to set item type in the second tab) 8 - The order has no price info! 9 - Apply patch 10 - Repeat 3-7 above, staging file fresh 11 - Confirm order has correct prices 12 - Test with a file with many records 13 - Confirm any combination of choosing/skipping records works as expected Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Works, makes sense, QA script happy, code looks good, passing QA :) --- (In reply to Katrin Fischer from comment #3) > I really wonder why we didn't stumble on this much sooner? Indeed! Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.06 Any reason this was not backported to 22.11? Created attachment 159713 [details] [review] Bug 35254: [22.11.x] Add import_record_id to order inputs This patch follows the logic of bug 32166 and adds specific inputs for each order to avoid any misalignment when some records are not imported To test: 1 - Find a vendor in acquisitions 2 - Create or find an open basket 3 - Add to basket form a new file 4 - Stage file and add to basket 5 - Select the second record in the list 6 - Enter price info 7 - Save (don't forget, you need to set item type in the second tab) 8 - The order has no price info! 9 - Apply patch 10 - Repeat 3-7 above, staging file fresh 11 - Confirm order has correct prices 12 - Test with a file with many records 13 - Confirm any combination of choosing/skipping records works as expected Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Pushed to 22.11.x for 22.11.13 Why is this set to REOPENED? My fault, I did that for attention for backporting Closing now Okay thanks! I thought maybe there was a problem with the patch that needed to be fixed. |