Summary: | Updating po files locally fails | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | I18N/L10N | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | f.demians, fridolin.somers, jonathan.druart |
Version: | Main | Keywords: | rel_23_11_candidate |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
Circulation function: | |||
Bug Depends on: | 34587 | ||
Bug Blocks: | |||
Attachments: |
Bug 35258: Remove uneeded comment and fix po:update
Bug 35258: Remove uneeded comment and fix po:update |
Description
Katrin Fischer
2023-11-04 19:25:36 UTC
It's working for me. $ gulp po:update --lang de-DE [10:35:43] Using gulpfile /kohadevbox/koha/gulpfile.js [10:35:43] Starting 'po:update'... [10:35:43] Starting 'po_update_marc_marc21'... [10:35:43] Starting 'po_update_marc_unimarc'... [10:35:43] Starting 'po_update_staff'... [10:35:43] Starting 'po_update_opac'... [10:35:43] Starting 'po_update_pref'... [10:35:43] Starting 'po_update_messages'... [10:35:43] Starting 'po_update_messages_js'... [10:35:43] Starting 'po_update_installer'... [10:35:43] Starting 'po_update_installer_marc21'... [10:35:43] Starting 'po_update_installer_unimarc'... [10:35:46] Finished 'po_update_installer_unimarc' after 3.1 s [10:35:46] Finished 'po_update_installer' after 3.13 s [10:35:46] Finished 'po_update_installer_marc21' after 3.22 s [10:35:46] Finished 'po_update_pref' after 3.55 s [10:35:46] Finished 'po_update_messages_js' after 3.73 s [10:35:47] Finished 'po_update_marc_unimarc' after 4.46 s [10:35:47] Finished 'po_update_opac' after 4.59 s [10:35:48] Finished 'po_update_marc_marc21' after 5.25 s [10:35:49] Finished 'po_update_messages' after 6.68 s [10:35:52] Finished 'po_update_staff' after 9.87 s [10:35:52] Finished 'po:update' after 9.87 s Can you remove node_modules and try again? Which OS are you on? root@kohadevbox:koha$ lsb_release -a No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 12 (bookworm) Release: 12 Codename: bookworm root@kohadevbox:koha$ gettext --version gettext (GNU gettext-runtime) 0.21 (In reply to Jonathan Druart from comment #2) > Which OS are you on? > > root@kohadevbox:koha$ lsb_release -a > No LSB modules are available. > Distributor ID: Debian > Description: Debian GNU/Linux 12 (bookworm) > Release: 12 > Codename: bookworm > > root@kohadevbox:koha$ gettext --version > gettext (GNU gettext-runtime) 0.21 Hm my ktd replies: No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 11 (bullseye) Release: 11 Codename: bullseye gettext (GNU gettext-runtime) 0.21 Can you pull new ktd images? If it still fails can you try with debian 12? Make sure you don't have node_modules and run the command within ktd's container. Caused by commit 033b683813ec061f6fbb6038f7245f0fa0ffeedd Bug 34587: Add data providers components and sub-components Recreating on D11. Created attachment 158622 [details] [review] Bug 35258: Remove uneeded comment and fix po:update This comment was breaking gulp po:update on D11 koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesShow.vue:82: warning: unterminated string Aborted (core dumped) at ChildProcess.exithandler (node:child_process:419:12) at ChildProcess.emit (node:events:514:28) at ChildProcess.emit (node:domain:552:15) at maybeClose (node:internal/child_process:1091:16) at Socket.<anonymous> (node:internal/child_process:449:11) at Socket.emit (node:events:514:28) at Socket.emit (node:domain:552:15) at Pipe.<anonymous> (node:net:323:12) at Pipe.callbackTrampoline (node:internal/async_hooks:130:17) [19:23:07] 'po:update' errored after 1.14 s Created attachment 158624 [details] [review] Bug 35258: Remove uneeded comment and fix po:update This comment was breaking gulp po:update on D11 koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesShow.vue:82: warning: unterminated string Aborted (core dumped) at ChildProcess.exithandler (node:child_process:419:12) at ChildProcess.emit (node:events:514:28) at ChildProcess.emit (node:domain:552:15) at maybeClose (node:internal/child_process:1091:16) at Socket.<anonymous> (node:internal/child_process:449:11) at Socket.emit (node:events:514:28) at Socket.emit (node:domain:552:15) at Pipe.<anonymous> (node:net:323:12) at Pipe.callbackTrampoline (node:internal/async_hooks:130:17) [19:23:07] 'po:update' errored after 1.14 s Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Now that the line has been found, it's an obvious fix. Moving to PQA. Pushed to master for 23.11. Nice work everyone, thanks! Depends on Bug 34587 not in 23.05.x |