| Summary: | Update patron import to use protected column | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Cook <dcook> |
| Component: | Patrons | Assignee: | David Cook <dcook> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle.m.hall, magnus, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 26170 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 35264: Add "protected" column to patron import
Bug 35264: Add "protected" column to patron import |
||
|
Description
David Cook
2023-11-06 05:24:03 UTC
Created attachment 158486 [details] [review] Bug 35264: Add "protected" column to patron import This change adds the "protected" column to patron import. Test plan: 0. Apply the patch and run "restart_all" 1. prove -v t/db_dependent/Koha/Patrons/Import.t 2. Go to http://localhost:8081/cgi-bin/koha/tools/import_borrowers.pl 3. Note "protected" is listed in the "fields you want to supply" on the right side of the screen 4. Note "protected" appears in file downloaded by clicking "Download a Starter CSV file with all the columns" 5. Note that "Protected" appears after clicking "Enter default values" and after clicking "Preserve existing values" 6. For bonus marks, use the "Starter CSV file" to import a test patron (remember surname, branchcode, and categorycode are the required fields) Thanks David.. I was just looking at this myself. I wasn't yet sure whether the fix was here as you've suggested or whether we should be deleting the key when not present.. or a mix of both. Digging a bit deeper now. Created attachment 158494 [details] [review] Bug 35264: Add "protected" column to patron import This change adds the "protected" column to patron import. Test plan: 0. Apply the patch and run "restart_all" 1. prove -v t/db_dependent/Koha/Patrons/Import.t 2. Go to http://localhost:8081/cgi-bin/koha/tools/import_borrowers.pl 3. Note "protected" is listed in the "fields you want to supply" on the right side of the screen 4. Note "protected" appears in file downloaded by clicking "Download a Starter CSV file with all the columns" 5. Note that "Protected" appears after clicking "Enter default values" and after clicking "Preserve existing values" 6. For bonus marks, use the "Starter CSV file" to import a test patron (remember surname, branchcode, and categorycode are the required fields) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Going straight for a QA here as it get tests passing again. All works as designed and resolves the issue. Thanks for jumping on it David. Passing QA Thanks for jumping on this before I could get round to it. You guys are awesome! Pushed to master for 23.11. Nice work everyone, thanks! |