| Summary: | addbiblio.pl calls generate_subfield_form with inconsistent parameters | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Mark Hofstetter <koha> |
| Component: | Cataloging | Assignee: | Mark Hofstetter <koha> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | koha, m.de.rooy, phil |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33669 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35288 |
||
| Change sponsored?: | Sponsored | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 35288 | ||
| Attachments: | Bug 35289: addbiblio.pl calls generate_subfield_form with inconsistent parameters | ||
Created attachment 158663 [details] [review] Bug 35289: addbiblio.pl calls generate_subfield_form with inconsistent parameters ApplyFrameworkDefaults works only for tags smaller than 10 this seems to be because addbiblio.pl calls $biblio_form_builder->generate_subfield_form 4 times(!) three of them are missing (at least) the following 3 paramters op => scalar $input->param('op'), changed_framework => scalar $input->param('changed_framework'), breedingid => scalar $input->param('breedingid'), so Koha::UI::Form::Builder::Biblio checks for ( $applydefaults =~ /new/ && !$self->{biblionumber} ) || ( $applydefaults =~ /duplicate/ && $op eq 'duplicate' ) || ( $applydefaults =~ /changed/ && $changed_framework ) || ( $applydefaults =~ /imported/ && $breedingid ) and this works only for the "new" case, this patch fixes this error To test: 1) you need: one record, two frameworks including both of them including a marc field X (tag > 10) 2) record should be in framework A, marcfield X should be empty 3) define a defaultvalue for marcfield X in framework B 4) "edit record", change framework (setting) to framework B 5) marcfield X remains emtpy, which is an error imho 6) Apply patch 7) repeat step 4 8) marcfield X should now have the default value 9) please Sign off Sponsored-by: Styrian State Library Co-authored-by: Thomas Klausner <domm@plix.at> similar testing should be done for the duplicate and import case |
in addbiblio.pl $biblio_form_builder->generate_subfield_form is called 4 times(!) three of them are missing (at least) the following 3 paramters op => scalar $input->param('op'), changed_framework => scalar $input->param('changed_framework'), breedingid => scalar $input->param('breedingid'), this means that "ApplyFrameworkDefaults" (see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35288 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33669) only works for tags smaller then 10. If this is intentionel its done rather weirdly fix follows