Summary: | Allow for items with specific not for loan values to appear in the holds queue | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Hold requests | Assignee: | Bugs List <koha-bugs> |
Status: | NEW --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | clemens.tubach, gmcharlt, hebah, januszop, kebliss, lisette, michaela.sieber, mirjam.vantieghem, nick, rcoert |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10591 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37022 |
||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: |
Description
Katrin Fischer
2023-11-09 08:47:42 UTC
+1 +1 If I may comment it: I perfectly understand the use case. We solve it by assigning notforloan = 0 and restricted = 1 in such cases. The user sees then: "Available (Restricted access)" (in green) as item status. What would serve, however, would be a possibility to on-site check-out those restricted items. Wouldn't be enough? (In reply to Janusz Kaczmarek from comment #3) > If I may comment it: I perfectly understand the use case. We solve it by > assigning notforloan = 0 and restricted = 1 in such cases. The user sees > then: "Available (Restricted access)" (in green) as item status. > > What would serve, however, would be a possibility to on-site check-out those > restricted items. > > Wouldn't be enough? Restricted = 1 cannot be checked out - not even as an on-site, IRRC? (In reply to Katrin Fischer from comment #4) > (In reply to Janusz Kaczmarek from comment #3) > > If I may comment it: I perfectly understand the use case. We solve it by > > assigning notforloan = 0 and restricted = 1 in such cases. The user sees > > then: "Available (Restricted access)" (in green) as item status. > > > > What would serve, however, would be a possibility to on-site check-out those > > restricted items. > > > > Wouldn't be enough? > > Restricted = 1 cannot be checked out - not even as an on-site, IRRC? Exactly. Interestingly, only == 1, but not for other values (no idea why so). A tiny patch like: diff --git a/C4/Circulation.pm b/C4/Circulation.pm index a9f32c34e8..72aae56c69 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -1052,7 +1052,8 @@ sub CanBookBeIssued { $issuingimpossible{WTHDRAWN} = 1; } if ( $item_object->restricted - && $item_object->restricted == 1 ) + && $item_object->restricted == 1 + && ! $onsite_checkout ) { $issuingimpossible{RESTRICTED} = 1; } would make on-site check-outs of such materials possible. If it looks like a good idea I could prepare an official patch (I patch this in some of my installations anyway). There is a very old discussion about how restricted should be used and what it's supposed to do - which makes it hard to change behavior now, as we don't know how libraries have been using it so far (bug 10591) Another issue with the restricted: If you want to do a proper checkout, you can't overwrite right now. So it's really a hard block. Maybe THAT is a use case some libraries need? The behavior for 'not for loan' with the negative and positive values on the other hand is clear and it could fit in with SkipHoldTrapOnNotForLoanValue and TrapHoldsOnOrder. |