|
Description
Owen Leonard
2023-11-16 13:47:47 UTC
Created attachment 159051 [details] [review] Bug 35350: Update label creator pop-up windows with consistent footer markup This patch updates two label creator templates in order to style submission and close buttons in a fixed footer at the bottom of the window, with markup consistent with other pop-up windows. To test, apply the patch and go to Cataloging -> Label creator. - Click New -> Label batch. - Click the "Add items" button under the form. - A "Search for items" window should pop up. - The window's fixed footer should have the "Search" and "Close window" buttons. Test that each work correctly. - Submit a search which will return results. - The search results window should also have a fixed footer. I moved the "Add checked" and "Done" buttons out of a floating toolbar and put the controls there for consistency's sake. - Confirm that both controls work correctly. Created attachment 159457 [details] [review] Bug 35350: Update label creator pop-up windows with consistent footer markup This patch updates two label creator templates in order to style submission and close buttons in a fixed footer at the bottom of the window, with markup consistent with other pop-up windows. To test, apply the patch and go to Cataloging -> Label creator. - Click New -> Label batch. - Click the "Add items" button under the form. - A "Search for items" window should pop up. - The window's fixed footer should have the "Search" and "Close window" buttons. Test that each work correctly. - Submit a search which will return results. - The search results window should also have a fixed footer. I moved the "Add checked" and "Done" buttons out of a floating toolbar and put the controls there for consistency's sake. - Confirm that both controls work correctly. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Created attachment 159465 [details] [review] Bug 35350: Update label creator pop-up windows with consistent footer markup This patch updates two label creator templates in order to style submission and close buttons in a fixed footer at the bottom of the window, with markup consistent with other pop-up windows. To test, apply the patch and go to Cataloging -> Label creator. - Click New -> Label batch. - Click the "Add items" button under the form. - A "Search for items" window should pop up. - The window's fixed footer should have the "Search" and "Close window" buttons. Test that each work correctly. - Submit a search which will return results. - The search results window should also have a fixed footer. I moved the "Add checked" and "Done" buttons out of a floating toolbar and put the controls there for consistency's sake. - Confirm that both controls work correctly. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Created attachment 159466 [details] [review] Bug 35350: Update label creator pop-up windows with consistent footer markup This patch updates two label creator templates in order to style submission and close buttons in a fixed footer at the bottom of the window, with markup consistent with other pop-up windows. To test, apply the patch and go to Cataloging -> Label creator. - Click New -> Label batch. - Click the "Add items" button under the form. - A "Search for items" window should pop up. - The window's fixed footer should have the "Search" and "Close window" buttons. Test that each work correctly. - Submit a search which will return results. - The search results window should also have a fixed footer. I moved the "Add checked" and "Done" buttons out of a floating toolbar and put the controls there for consistency's sake. - Confirm that both controls work correctly. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> I tested it on a new sandbox and it worked great. Created attachment 161500 [details] [review] Bug 35350: Update label creator pop-up windows with consistent footer markup This patch updates two label creator templates in order to style submission and close buttons in a fixed footer at the bottom of the window, with markup consistent with other pop-up windows. To test, apply the patch and go to Cataloging -> Label creator. - Click New -> Label batch. - Click the "Add items" button under the form. - A "Search for items" window should pop up. - The window's fixed footer should have the "Search" and "Close window" buttons. Test that each work correctly. - Submit a search which will return results. - The search results window should also have a fixed footer. I moved the "Add checked" and "Done" buttons out of a floating toolbar and put the controls there for consistency's sake. - Confirm that both controls work correctly. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice consistency fix, no regressions. Passing QA Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.03 |