| Summary: | Cannot hide SMSalertnumber via BorrowerUnwantedField | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Patrons | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | Pushed to oldoldstable --- | QA Contact: | Victor Grousset/tuxayo <victor> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | andrew, fridolin.somers, gmcharlt, kyle.m.hall, phil, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.01,23.05.07
|
|
| Circulation function: | |||
| Attachments: |
Bug 35352: Allow SMSalertnumber to be hidden via BorrowerUnwantedField
Bug 35352: Allow SMSalertnumber to be hidden via BorrowerUnwantedField Bug 35352: Allow SMSalertnumber to be hidden via BorrowerUnwantedField |
||
|
Description
Lucas Gass (lukeg)
2023-11-16 14:58:12 UTC
Created attachment 159054 [details] [review] Bug 35352: Allow SMSalertnumber to be hidden via BorrowerUnwantedField To test: 1. Add a value to SMSSendDriver like 'Emial'. 2. Go to BorrowerUnwantedField and attempt to hide "Mobile phone number (smsalertnumber)" 3. Go to members/memberentry.pl and see the field is not hidden. 4. APPLY PATCH 5. Try step 3 again and this time the field should be properly hidden. Note: This patch also includes some indentation changes. Created attachment 159068 [details] [review] Bug 35352: Allow SMSalertnumber to be hidden via BorrowerUnwantedField To test: 1. Add a value to SMSSendDriver like 'Emial'. 2. Go to BorrowerUnwantedField and attempt to hide "Mobile phone number (smsalertnumber)" 3. Go to members/memberentry.pl and see the field is not hidden. 4. APPLY PATCH 5. Try step 3 again and this time the field should be properly hidden. Note: This patch also includes some indentation changes. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> This works as described. With the patch applied, the SMS Number field still shows up under the messaging pref box on moremember.pl. It kinda feels like setting it in BorrowerUnwanted should also hide it on moremember.pl. Also, I just filed bug 35356 to suggest we not show SMS Number on moremember.pl at all if the patron doesn't have a value for that in their record. Created attachment 159074 [details] [review] Bug 35352: Allow SMSalertnumber to be hidden via BorrowerUnwantedField To test: 1. Add a value to SMSSendDriver like 'Emial'. 2. Go to BorrowerUnwantedField and attempt to hide "Mobile phone number (smsalertnumber)" 3. Go to members/memberentry.pl and see the field is not hidden. 4. APPLY PATCH 5. Try step 3 again and this time the field should be properly hidden. Note: This patch also includes some indentation changes. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> (In reply to Andrew Fuerste-Henry from comment #3) > With the patch applied, the SMS Number field still shows up under the > messaging pref box on moremember.pl. It kinda feels like setting it in > BorrowerUnwanted should also hide it on moremember.pl. > Also, I just filed bug 35356 to suggest we not show SMS Number on > moremember.pl at all if the patron doesn't have a value for that in their > record. Good observation thanks for the new ticket :) Works, makes sense, QA script happy, code looks good, passing QA :) Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.01 Backported to 23.05.x for upcoming 23.05.07 |