| Summary: | Checked In item requiring transfer does not consistently trigger transfer prompt | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Mickey Coalwell <mcoalwell> |
| Component: | Circulation | Assignee: | Chris Cormack <chris> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, cookie.wolfrom, dschust1, gmcharlt, jwagner, koha.sekjal, nahuel.angelinetti, nengard, oleonard, smoreland |
| Version: | rel_3_2 | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Showing On Hold Items on Search Results
bugfix Patch for bugfix on master branch Patch for master Modified patch, signed off revised patch, improved formatting |
||
|
Description
Chris Cormack
2010-05-21 01:11:52 UTC
Patch hasn't been pushed yet. Will follow up with Galen Checking in on the status of this patch Updating version as described in http://wiki.koha-community.org/wiki/General_IRC_Meeting,_7_July_2010 Sharon Moreland at NEKLS reports similar problems with these circumstances: When an item belonging to Library A is returned at Library B, a transfer prompt is displayed ONLY when that item is being checked in after issue. A transfer prompt does NOT display in these other instances where currentlocation != homebranch: 1. When an item arrives at Library to fill a hold that has been canceled (bug 3270) 2. When an item marked LOST or CLAIMS RETURNED is checked in (after being found). 3. When an item that is not checked out (taken without being checked out or reshelved after transfer prompt overlooked) is checked in System preferences settings: AutomaticItemReturn is ON and HomeOrHoldingBranch is 'holding branch' ----- sekjal did extensive testing on the IRC today (see the logs) with the proposed patch, and it does not seem to fix all the problems. I am wondering if the simpler fix wouldn't be to make the checkin code obey the AutomaticItemReturn in cases where the item is not presently checked out. Haven't dug into the code yet myself to check this as an option. Testing the patch as applied to the bug_3536_holeorholdbranchreturn branch at http://git.librarypolice.com/?p=koha-rm.git;a=summary: Using both a book and a patron from Library A With HomeOrHoldingBranchReturn = 'homebranch': checkout A, return B => transfer message, B -> A checkout B, return B => transfer message, B -> A checkout B, return A => no message this seems to be desirable behaviour With HomeOrHoldingBranchReturn = 'holdingbranch': checkout A, return B => transfer message, B -> A checkout B, return B => no message checkout B, return A => first a transfer message B -> A (which marks the item as in transit A -> B) ...upon second return to A => a transfer message, A -> B. In transit message stays the same ...upon third return to B => no message, item rests with homebranch = A and holdingbranch = B If the first transfer message were removed from the final case, this would seem to be desirable behaviour Testing did not show any effect from HomeOrHoldingBranch's value. Testing did not factor in the AutomaticItemReturn system preference, was set to 'Do' for all tests. Created attachment 2615 [details] [review] Modified patch, signed off This version of the patch adds support in circ/returns.pl for return branches other than Homebranch. Before, if a transfer was required, the message displayed would always indicate the items should be transferred to it's Homebranch, even if HomeOrHoldingBranchReturn was set to 'holdingbranch' Created attachment 2616 [details] [review] revised patch, improved formatting Previous submission may not have been in a desirable format for application; reattaching. Patch pushed to HEAD for inclusion in 3.2. Leaving bug open but downgrading priority because of minor cosmetic change need to add to circulation.pref. This preference is in the local use tab and not where it belongs. Whats the current status of this? Marking fixed because in my tests an item belonging to another branch will trigger the "Please return to..." message when checked in even if it is not checked out. |