Bug 35365

Summary:	Incorrectly closed <th> tag on patron search page
Product:	Koha	Reporter:	Brendan Lawlor <blawlor>
Component:	Accessibility	Assignee:	Brendan Lawlor <blawlor>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	trivial
Priority:	P5 - low	CC:	lucas, martin.renvoize, matt.blenkinsop, oleonard
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.11.00
Circulation function:
Attachments:	Bug 35365: fix stray td tag Bug 35365: fix stray td tag

Description Brendan Lawlor 2023-11-17 21:03:50 UTC

In /koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc

On line 160 there is a incorrectly close <th> tag 
[% CASE 'dateexpiry' %]<th>Expires on</td>

Comment 1 Brendan Lawlor 2023-11-17 21:43:40 UTC

Created attachment 159115 [details] [review]
Bug 35365: fix stray td tag

Comment 2 Lucas Gass (lukeg) 2023-11-17 21:49:17 UTC

Created attachment 159116 [details] [review]
Bug 35365: fix stray td tag

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Comment 3 Lucas Gass (lukeg) 2023-11-17 21:50:14 UTC

Thanks Brendan, looks good! Straighforward fix here, passing QA.

Comment 4 Brendan Lawlor 2023-11-17 22:01:49 UTC

I had trouble with git commit --amend to add the test plan

To test:
  1. Run any page that contains the Search patrons search bar through an HTML validator
  2. See Error stray end tag td
  3. Apply patch
  4. Run the page through the HTML validator again
  5. See the stray end tag error go away
  6. Test that patron search still works

Comment 5 Tomás Cohen Arazi (tcohen) 2023-11-24 00:13:31 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!