Summary: | Hide 'Transfers to send' on circulation home page when stock rotation is disabled | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Staff interface | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37236 |
||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
Currently, Transfers to send (on circulation) is only relevant when you enable StockRotation. To lower confusion, we hide the option if you did not enable that pref.
|
Version(s) released in: |
24.05.00,23.11.03
|
Circulation function: | |||
Bug Depends on: | 22569 | ||
Bug Blocks: | |||
Attachments: |
Bug 35389: Hide 'Transfer to send' if StockRotation disabled
Bug 35389: Hide 'Transfer to send' if StockRotation disabled Bug 35389: (QA follow-up) Update circ-nav too |
Description
Marcel de Rooy
2023-11-23 09:06:02 UTC
Created attachment 159204 [details] [review] Bug 35389: Hide 'Transfer to send' if StockRotation disabled Test plan: Disable StockRotation pref. Check if report is hidden on circ home. Enable. Check if report is visible. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Very trivial: self SO Created attachment 160816 [details] [review] Bug 35389: Hide 'Transfer to send' if StockRotation disabled Test plan: Disable StockRotation pref. Check if report is hidden on circ home. Enable. Check if report is visible. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> I was sure this was used outside of just Stock rotation, but I'm assured the report is always empty in that case. We can pass this through and undo it if we get feeback to the contrary. Please also update the circulation sidebar with the same preference check. Created attachment 161178 [details] [review] Bug 35389: (QA follow-up) Update circ-nav too As Katrin spotted, we need to not forget the sidebar menu. Test plan: Check if the item is visible/invisible on the sidebar menu of Circulation. (Depending on StockRotation pref.) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> (In reply to Katrin Fischer from comment #5) > Please also update the circulation sidebar with the same preference check. Good catch. Fixed. Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.03 |