Bug 35425

Summary:	Sortable prevents mouse selection of text inside child input/textarea elements
Product:	Koha	Reporter:	Slava Shishkin <slavashishkin>
Component:	Cataloging	Assignee:	Slava Shishkin <slavashishkin>
Status:	RESOLVED FIXED	QA Contact:	Marcel de Rooy <m.de.rooy>
Severity:	normal
Priority:	P5 - low	CC:	fridolin.somers, lucas, m.de.rooy, phil
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	24.05.00,23.11.01
Circulation function:
Bug Depends on:	35383
Bug Blocks:
Attachments:	Bug 35425: Optimize UX when dragging a Tag or Subfield Bug 35425: Optimize UX when dragging a Tag or Subfield Bug 35425: Optimize UX when dragging a Tag or Subfield

Description Slava Shishkin 2023-11-28 18:42:39 UTC

To reproduce:
1. Open any biblio and edit that record. 
   (select "Edit record" from the "Edit" drop-down menu).
2. Check that selecting the text in any draggable block input/textarea fields with a mouse is not possible - it starts dragging instantly.

Comment 1 Slava Shishkin 2023-11-28 19:18:16 UTC

Created attachment 159313 [details] [review]
Bug 35425: Optimize UX when dragging a Tag or Subfield

To reproduce:
1. Open any biblio and edit that record. 
   (select "Edit record" from the "Edit" drop-down menu).
2. Check that selecting the text in any draggable block input/textarea 
   fields with a mouse is not possible - it starts dragging instantly.
3. Apply the patch
4. Make sure that draging is activated only when you click 
   on the "::" icon in front of the dragged item. And text selection 
   works correctly.

Comment 2 Phil Ringnalda 2023-11-29 22:55:38 UTC

Created attachment 159379 [details] [review]
Bug 35425: Optimize UX when dragging a Tag or Subfield

To reproduce:
1. Open any biblio and edit that record.
   (select "Edit record" from the "Edit" drop-down menu).
2. Check that selecting the text in any draggable block input/textarea
   fields with a mouse is not possible - it starts dragging instantly.
3. Apply the patch
4. Make sure that draging is activated only when you click
   on the "::" icon in front of the dragged item. And text selection
   works correctly.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>

Comment 3 Marcel de Rooy 2023-12-01 07:47:17 UTC

Created attachment 159426 [details] [review]
Bug 35425: Optimize UX when dragging a Tag or Subfield

To reproduce:
1. Open any biblio and edit that record.
   (select "Edit record" from the "Edit" drop-down menu).
2. Check that selecting the text in any draggable block input/textarea
   fields with a mouse is not possible - it starts dragging instantly.
3. Apply the patch
4. Make sure that draging is activated only when you click
   on the "::" icon in front of the dragged item. And text selection
   works correctly.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Comment 4 Katrin Fischer 2023-12-11 18:12:14 UTC

More a bug than an enh!

Comment 5 Katrin Fischer 2023-12-11 18:19:06 UTC

This fixes the buggy behavior, but in testing this I feel like we might think about improving UX a bit more (on a separate bug). I believe that our drag & drop is not very accessible and a little hard to handle when you are on a slow system.

Comment 6 Katrin Fischer 2023-12-11 18:47:08 UTC

Pushed for 24.05!

Well done everyone, thank you!

Comment 7 Fridolin Somers 2023-12-12 07:39:31 UTC

Pushed to 23.11.x for 23.11.01

Comment 8 Lucas Gass (lukeg) 2023-12-14 21:18:28 UTC

Missing dependencies for 23.05.x, no backport.