Summary: | Preservation system preferences should be authorised value pull downs | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | barbara.johnson, fridolin.somers, lucas, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.01
|
|
Circulation function: | |||
Attachments: |
Bug 35450: Preservation system preferences should authval dropdowns
Bug 35450: Preservation system preferences should authval dropdowns Bug 35450: Preservation system preferences should authval dropdowns |
Description
Katrin Fischer
2023-11-30 10:32:42 UTC
... these also should be pull downs with the values (like we do for lost now) instead of input fields. Created attachment 159463 [details] [review] Bug 35450: Preservation system preferences should authval dropdowns This patch updates two preservation module system preferences so that they offer dropdowns of "Not for loan" values instead of requiring entry of a specific code. The patch also adds a missing "." at the end of one preference description. To test, apply the patch and restart services. - Go to Administration -> System preferences. - Search for "preservation" - Check that the "PreservationNotForLoanDefaultTrainIn" and "PreservationNotForLoanWaitingListIn" preferences have dropdowns offering "Not for loan" values. - Confirm that your choices are correctly saved. Created attachment 159482 [details] [review] Bug 35450: Preservation system preferences should authval dropdowns This patch updates two preservation module system preferences so that they offer dropdowns of "Not for loan" values instead of requiring entry of a specific code. The patch also adds a missing "." at the end of one preference description. To test, apply the patch and restart services. - Go to Administration -> System preferences. - Search for "preservation" - Check that the "PreservationNotForLoanDefaultTrainIn" and "PreservationNotForLoanWaitingListIn" preferences have dropdowns offering "Not for loan" values. - Confirm that your choices are correctly saved. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Created attachment 159666 [details] [review] Bug 35450: Preservation system preferences should authval dropdowns This patch updates two preservation module system preferences so that they offer dropdowns of "Not for loan" values instead of requiring entry of a specific code. The patch also adds a missing "." at the end of one preference description. To test, apply the patch and restart services. - Go to Administration -> System preferences. - Search for "preservation" - Check that the "PreservationNotForLoanDefaultTrainIn" and "PreservationNotForLoanWaitingListIn" preferences have dropdowns offering "Not for loan" values. - Confirm that your choices are correctly saved. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Good catch, it was possible to save any value in the syspref [U+1F4A5] :o Works, makes sense, QA script happy, code looks good, passing QA :) Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.01 Not needed in 23.05.x, no backport. |