Bug 35453

Summary:	Wrong 'Laserdisc)' string on 007 builder (MARC21)
Product:	Koha	Reporter:	Tomás Cohen Arazi (tcohen) <tomascohen>
Component:	Templates	Assignee:	Tomás Cohen Arazi (tcohen) <tomascohen>
Status:	Pushed to oldoldstable ---	QA Contact:	Testopia <testopia>
Severity:	minor
Priority:	P5 - low	CC:	fridolin.somers, lucas, phil, tomascohen, victor
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	String patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	24.05.00,23.11.01,23.05.07
Circulation function:
Attachments:	Bug 35453: Fix wrong 'Laserdisc)' string on 007 builder (MARC21) Bug 35453: Fix wrong 'Laserdisc)' string on 007 builder (MARC21) Bug 35453: Fix wrong 'Laserdisc)' string on 007 builder (MARC21)

Description Tomás Cohen Arazi (tcohen) 2023-11-30 12:42:55 UTC

Cosmetic issue.

Steps to reproduce:
- On cataloguing, open the 007 builder.
- Choose material type 'Video recording'
- On 04 choose g - Laserdisc
- Click save
=> SUCCESS: 'g' correctly shows on the 007
- Edit the 007 again
=> FAIL: on 04, 'g - Laserdisc)' is displayed

Comment 1 Tomás Cohen Arazi (tcohen) 2023-11-30 12:49:22 UTC

Created attachment 159396 [details] [review]
Bug 35453: Fix wrong 'Laserdisc)' string on 007 builder (MARC21)

Steps to reproduce:
1. On cataloguing, open the 007 builder.
2. Choose material type 'Video recording'
3. On 04 choose g - Laserdisc
4. Click save
=> SUCCESS: 'g' correctly shows on the 007
5. Edit the 007 again
=> FAIL: on 04, 'g - Laserdisc)' is displayed
6. Apply this patch
7. Repeat 4 and 5
=> SUCCESS: no trailing ')'
8. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Comment 2 David Nind 2023-11-30 18:30:17 UTC

Created attachment 159417 [details] [review]
Bug 35453: Fix wrong 'Laserdisc)' string on 007 builder (MARC21)

Steps to reproduce:
1. On cataloguing, open the 007 builder.
2. Choose material type 'Video recording'
3. On 04 choose g - Laserdisc
4. Click save
=> SUCCESS: 'g' correctly shows on the 007
5. Edit the 007 again
=> FAIL: on 04, 'g - Laserdisc)' is displayed
6. Apply this patch
7. Repeat 4 and 5
=> SUCCESS: no trailing ')'
8. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>

Comment 3 Victor Grousset/tuxayo 2023-12-07 07:10:14 UTC

Created attachment 159632 [details] [review]
Bug 35453: Fix wrong 'Laserdisc)' string on 007 builder (MARC21)

Steps to reproduce:
1. On cataloguing, open the 007 builder.
2. Choose material type 'Video recording'
3. On 04 choose g - Laserdisc
4. Click save
=> SUCCESS: 'g' correctly shows on the 007
5. Edit the 007 again
=> FAIL: on 04, 'g - Laserdisc)' is displayed
6. Apply this patch
7. Repeat 4 and 5
=> SUCCESS: no trailing ')'
8. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

Comment 4 Victor Grousset/tuxayo 2023-12-07 07:10:56 UTC

Works, makes sense, QA script happy, code looks good, passing QA :)

Comment 5 Katrin Fischer 2023-12-07 11:05:51 UTC

Pushed for 24.05!

Well done everyone, thank you!

Comment 6 Fridolin Somers 2023-12-07 21:23:04 UTC

Pushed to 23.11.x for 23.11.01

Comment 7 Lucas Gass (lukeg) 2023-12-14 20:58:37 UTC

Backported to 23.05.x for upcoming 23.05.07