Description
Lari Taskula
2023-12-01 22:41:12 UTC
Created attachment 159486 [details] [review] Bug 35471: Add column parent_frameworkcode to table biblio_framework Sponsored-by: Hypernova Oy Created attachment 159487 [details] [review] Bug 35471: DBIx changes Sponsored-by: Hypernova Oy Created attachment 159488 [details] [review] Bug 35471: Add support for selecting parent framework on MARC framework modification screen To test: 1. Navigate to Administration -> MARC bibliographic framework 2. Create MARC framework with frameworkcode "A" 3. Observe new field "Parent framework" when adding a new framework 4. After adding the framework, click Actions -> MARC structure 5. Select "Create framework for A" using "Default", click OK 6. Navigate back to frameworks listing 7. Create framework with frameworkcode "A-1" 8. Select framework you created at step 2 as the parent framework 9. After adding the framework, click Actions -> MARC structure 10. Select "Create framework for A-1" using "Default", click OK Sponsored-by: Hypernova Oy Created attachment 159489 [details] [review] Bug 35471: List child frameworks on MARC modification screen 1. Navigate to Administration -> MARC bibliographic framework 2. Select the parent framework you added in previous patch 3. Observe child framework being listed Sponsored-by: Hypernova Oy Created attachment 159490 [details] [review] Bug 35471: List parent frameworks on MARC framework list screen 1. Navigate to Administration -> MARC bibliographic framework 2. Observe new column "Parent framework" 3. Observe parent framework being populated for the child framework you added in previous patch Sponsored-by: Hypernova Oy Created attachment 159491 [details] [review] Bug 35471: Add Koha::Template::Plugin::Frameworks->GetChildren() To test: 1. prove t/db_dependent/Koha/Template/Plugin/Frameworks.t Sponsored-by: Hypernova Oy Created attachment 159492 [details] [review] Bug 35471: Add child frameworks to cataloguing toolbar's new child record button To test: Administration -> MARC bibliographic framework 1. Create framework with frameworkcode "A" 2. Create framework with frameworkcode "A-child" 3. Set "A" as "A-child" 's parent framework Record view 1. Save record with framework "A" 2. Navigate to a record 3. Click "+ New", a drop-down opens 4. Click "New child record" 5. After add biblio form opens, click "Settings" 6. Observe "A-child" framework automatically selected Sponsored-by: Hypernova Oy Created attachment 159493 [details] [review] Bug 35471: Add child frameworks to cataloguing toolbar's new child record button To test: Administration -> MARC bibliographic framework 1. Create framework with frameworkcode "A" 2. Create framework with frameworkcode "A-1" 3. Set "A" as "A-1" 's parent framework Record view 1. Save record with framework "A" 2. Navigate to a record 3. Click "+ New", a drop-down opens 4. Click "New child record" 5. After add biblio form opens, click "Settings" 6. Observe "A-1" framework automatically selected Sponsored-by: Hypernova Oy Created attachment 159494 [details] [review] Bug 35471: Add column parent_frameworkcode to table biblio_framework Sponsored-by: Hypernova Oy Created attachment 159495 [details] [review] Bug 35471: DBIx changes Sponsored-by: Hypernova Oy Created attachment 159496 [details] [review] Bug 35471: Add support for selecting parent framework on MARC framework modification screen To test: 1. Navigate to Administration -> MARC bibliographic framework 2. Create MARC framework with frameworkcode "A" 3. Observe new field "Parent framework" when adding a new framework 4. After adding the framework, click Actions -> MARC structure 5. Select "Create framework for A" using "Default", click OK 6. Navigate back to frameworks listing 7. Create framework with frameworkcode "A-1" 8. Select framework you created at step 2 as the parent framework 9. After adding the framework, click Actions -> MARC structure 10. Select "Create framework for A-1" using "Default", click OK Sponsored-by: Hypernova Oy Created attachment 159497 [details] [review] Bug 35471: List child frameworks on MARC modification screen 1. Navigate to Administration -> MARC bibliographic framework 2. Select the parent framework you added in previous patch 3. Observe child framework being listed Sponsored-by: Hypernova Oy Created attachment 159498 [details] [review] Bug 35471: List parent frameworks on MARC framework list screen 1. Navigate to Administration -> MARC bibliographic framework 2. Observe new column "Parent framework" 3. Observe parent framework being populated for the child framework you added in previous patch Sponsored-by: Hypernova Oy Created attachment 159499 [details] [review] Bug 35471: Add Koha::Template::Plugin::Frameworks->GetChildren() To test: 1. prove t/db_dependent/Koha/Template/Plugin/Frameworks.t Sponsored-by: Hypernova Oy Created attachment 159500 [details] [review] Bug 35471: Add child frameworks to cataloguing toolbar's new child record button To test: Administration -> MARC bibliographic framework 1. Create framework with frameworkcode "A" 2. Create framework with frameworkcode "A-1" 3. Set "A" as "A-1" 's parent framework Record view 1. Save record with framework "A" 2. Navigate to a record 3. Click "+ New", a drop-down opens 4. Click "New child record" 5. After add biblio form opens, click "Settings" 6. Observe "A-1" framework automatically selected Sponsored-by: Hypernova Oy Created attachment 159567 [details] [review] Bug 35471: Add column parent_frameworkcode to table biblio_framework Sponsored-by: Hypernova Oy Created attachment 159568 [details] [review] Bug 35471: DBIx changes Sponsored-by: Hypernova Oy Created attachment 159569 [details] [review] Bug 35471: Add support for selecting parent framework on MARC framework modification screen To test: 1. Navigate to Administration -> MARC bibliographic framework 2. Create MARC framework with frameworkcode "A" 3. Observe new field "Parent framework" when adding a new framework 4. After adding the framework, click Actions -> MARC structure 5. Select "Create framework for A" using "Default", click OK 6. Navigate back to frameworks listing 7. Create framework with frameworkcode "A-1" 8. Select framework you created at step 2 as the parent framework 9. After adding the framework, click Actions -> MARC structure 10. Select "Create framework for A-1" using "Default", click OK Sponsored-by: Hypernova Oy Created attachment 159570 [details] [review] Bug 35471: List child frameworks on MARC modification screen 1. Navigate to Administration -> MARC bibliographic framework 2. Select the parent framework you added in previous patch 3. Observe child framework being listed Sponsored-by: Hypernova Oy Created attachment 159571 [details] [review] Bug 35471: List parent frameworks on MARC framework list screen 1. Navigate to Administration -> MARC bibliographic framework 2. Observe new column "Parent framework" 3. Observe parent framework being populated for the child framework you added in previous patch Sponsored-by: Hypernova Oy Created attachment 159572 [details] [review] Bug 35471: Add Koha::Template::Plugin::Frameworks->GetChildren() To test: 1. prove t/db_dependent/Koha/Template/Plugin/Frameworks.t Sponsored-by: Hypernova Oy Created attachment 159573 [details] [review] Bug 35471: Add child frameworks to cataloguing toolbar's new child record button To test: Administration -> MARC bibliographic framework 1. Create framework with frameworkcode "A" 2. Create framework with frameworkcode "A-1" 3. Set "A" as "A-1" 's parent framework Record view 1. Save record with framework "A" 2. Navigate to a record 3. Click "+ New", a drop-down opens 4. Click "New child record" 5. After add biblio form opens, click "Settings" 6. Observe "A-1" framework automatically selected Sponsored-by: Hypernova Oy I know qa-tools is complaining about tidiness, I tried my best fixing the issues but eventually had to give up as I'm not able to resolve them. KomodoIDE/perltidy v20230912/perltidy command line arguments: -pro=/kohapath/.perltidyrc , Code -> Format -> Selection using perltidy How do I know which lines are less tidy exactly? Can koha-qa tell me that? Created attachment 159884 [details] [review] Bug 35471: Add child frameworks to cataloguing toolbar's new child record button To test: Administration -> MARC bibliographic framework 1. Create framework with frameworkcode "A" 2. Create framework with frameworkcode "A-1" 3. Set "A" as "A-1" 's parent framework Record view 1. Save record with framework "A" 2. Navigate to a record 3. Click "+ New", a drop-down opens 4. Click "New child record" 5. After add biblio form opens, click "Settings" 6. Observe "A-1" framework automatically selected Sponsored-by: Hypernova Oy Signed-off-by: Päivi Knuutinen <paivi.knuutinen@joensuu.fi> I tested this at sandbox and it works. |