Summary: | Reverting waiting status for holds is not logged | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Architecture, internals, and plumbing | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, fridolin.somers, lucas, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.02,23.05.08
|
|
Circulation function: | |||
Attachments: |
Bug 35491: Add logging to RevertWaitingStatus
Bug 35491: Add logging to RevertWaitingStatus Bug 35491: Add logging to RevertWaitingStatus |
Description
Nick Clemens (kidclamp)
2023-12-05 16:27:34 UTC
Created attachment 159595 [details] [review] Bug 35491: Add logging to RevertWaitingStatus This patch simply adds a logaction line to RevertWaitingStatus To test: 1 - Enable HoldsLog 2 - Place a hold 3 - Fill the hold 4 - Revert the waiting status 5 - Note there is no action log added 6 - Apply patch 7 - Repeat 2-4 8 - Confirm you now have a MODIFY action logged for the reversion Created attachment 159604 [details] [review] Bug 35491: Add logging to RevertWaitingStatus This patch simply adds a logaction line to RevertWaitingStatus To test: 1 - Enable HoldsLog 2 - Place a hold 3 - Fill the hold 4 - Revert the waiting status 5 - Note there is no action log added 6 - Apply patch 7 - Repeat 2-4 8 - Confirm you now have a MODIFY action logged for the reversion Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Created attachment 159903 [details] [review] Bug 35491: Add logging to RevertWaitingStatus This patch simply adds a logaction line to RevertWaitingStatus To test: 1 - Enable HoldsLog 2 - Place a hold 3 - Fill the hold 4 - Revert the waiting status 5 - Note there is no action log added 6 - Apply patch 7 - Repeat 2-4 8 - Confirm you now have a MODIFY action logged for the reversion Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> About the HoldsLog syspref it's description says:
> any actions on holds (create, cancel, suspend, resume, etc).
I would say that there is no need to mention revert thanks to the "etc". Just mentioning that here in case that would actually be important to change.
Works, makes sense, QA script happy, code looks good, passing QA :)
Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.02 Backported to 23.05.x for upcoming 23.05.08 |