Bug 35504

Summary: Release team 24.05
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: AboutAssignee: Martin Renvoize (ashimema) <martin.renvoize>
Status: Pushed to oldstable --- QA Contact: Testopia <testopia>
Severity: blocker    
Priority: P5 - low CC: david, fridolin.somers, jake.deery, lucas, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02,23.05.09
Circulation function:
Bug Depends on: 33899    
Bug Blocks: 37003    
Attachments: Bug 35504: New cycle, new team :)
Bug 35504: Typo fix
Bug 35504: Corrections to team
Bug 35504: New cycle, new team :)
Bug 35504: Typo fix
Bug 35504: Corrections to team
Bug 35504: Add ktd maintainer
Bug 35504: New cycle, new team :)
Bug 35504: Typo fix
Bug 35504: Corrections to team
Bug 35504: Add ktd maintainer
Bug 35504: New cycle, new team :)
Bug 35504: Typo fix
Bug 35504: Corrections to team
Bug 35504: Add ktd maintainer
Bug 35504: New cycle, new team :)
Bug 35504: Typo fix
Bug 35504: Corrections to team
Bug 35504: Add ktd maintainer
Bug 35504: Corrections to wiki team
Bug 35504: Change 'Jenkins' to 'Continuous integration'
Bug 35504: Add full maintainers list into development branch
Bug 35504: Split list of ERM Topic experts
Bug 35504: Distinguish different RMaint and Topic Expert roles
How it all looks now

Description Katrin Fischer 2023-12-06 13:50:30 UTC

    
Comment 1 Martin Renvoize (ashimema) 2023-12-06 16:04:47 UTC
Created attachment 159624 [details] [review]
Bug 35504: New cycle, new team :)
Comment 2 Martin Renvoize (ashimema) 2023-12-06 16:07:18 UTC
Now is also a good time for a codename if you wanted one for this cycle...

The last codename we added was Rosalie.. I quite like the idea of something to highlight inclusivity?  You're our first female RM, aren't you.. at least to my knowledge?
Comment 3 Jake Deery 2023-12-06 16:26:08 UTC
How about Ada Lovelace, oft cited as the first computer programmer

Or Grace Hopper, who wrote one of the first ever linkers.

I think the others here at PTFS Europe had other great suggestions too :-)
Comment 4 Katrin Fischer 2023-12-06 18:20:05 UTC
Hedy Lamarr or Katherine Johnson (NASA mathematician) also come to mind :)

Overall I feel this should be a community decision not an RM one. We have a general meeting coming up in January. What about adding it to the agenda there?
Comment 5 David Nind 2023-12-06 20:04:14 UTC
Notes/questions from testing
~~~~~~~~~~~~~~~~~~~~~~~~~~~~

- Accessibility advocate: is empty on the About > Koha team > Current maintenance team, in the patch we have two listed (as per the roles page) and these show under individual names

- Website Maintainer: patch shows Liz Rea, but on the roles page this is empty; assuming she is continuing until new website is running(?)

- KTD maintainer: no role/section in the patch for KTD maintainer, but it is on the role page - I think this is the first time we have had this specific role

- Wiki Curator: George Williams also added his name on the roles page, but this is not included

- Wiki team member (shown as Wiki Curator(?)): Mason James not included (is on the roles page), Katrin Fisher is included (but not on the roles page - probably should be as she does lots of changes and tidy ups!) 

Names for release
~~~~~~~~~~~~~~~~~

I don't have any objections to having names for releases. However, I thought the Rosalie release was special - to commemorate her importance to the existence of Koha.

If we did have names, I think it should be in some way either library, information management, or Koha related - people important to these. Maybe, if there was a theme for the release (such as a major new module), it could be named after that, for example: the ERM release.

But, as Katrin says, for discussion at the next general meeting.
Comment 6 Katrin Fischer 2023-12-07 09:24:51 UTC
I added it to the agenda: 
https://wiki.koha-community.org/wiki/General_IRC_meeting_17_January_2024
Comment 7 Pedro Amorim 2023-12-12 11:11:09 UTC
Created attachment 159726 [details] [review]
Bug 35504: Typo fix
Comment 8 Martin Renvoize (ashimema) 2023-12-12 11:50:40 UTC
Created attachment 159727 [details] [review]
Bug 35504: Corrections to team

Correction of 'advocate' to 'advocates' to ensure they appear in the
team.

Addition of 'website' and 'wiki' handling to ensure they also appear
in the team.
Comment 9 Martin Renvoize (ashimema) 2023-12-12 11:54:17 UTC
(In reply to David Nind from comment #5)
> Notes/questions from testing
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> - Accessibility advocate: is empty on the About > Koha team > Current
> maintenance team, in the patch we have two listed (as per the roles page)
> and these show under individual names

Follow-up corrects this.

> 
> - Website Maintainer: patch shows Liz Rea, but on the roles page this is
> empty; assuming she is continuing until new website is running(?)

Website manager has actually never been properly handled in the 'team' output. Follow-up corrects this too.

> 
> - KTD maintainer: no role/section in the patch for KTD maintainer, but it is
> on the role page - I think this is the first time we have had this specific
> role

New role, Will add a follow-up for this too.

> 
> - Wiki Curator: George Williams also added his name on the roles page, but
> this is not included
>
> - Wiki team member (shown as Wiki Curator(?)): Mason James not included (is
> on the roles page), Katrin Fisher is included (but not on the roles page -
> probably should be as she does lots of changes and tidy ups!)

Wiki has never been properly handled on the team section.. we aught to split them up to match the roles we now have in that team.  I've added basic handling in the follow-up but think the retrospective job of fixing teams going back to whenenever the various different wiki roles were introduced should fit in another bug.

> 
> Names for release
> ~~~~~~~~~~~~~~~~~
> 
Agree.. lets do this in a meeting.
Comment 10 Martin Renvoize (ashimema) 2023-12-12 12:06:09 UTC
Created attachment 159730 [details] [review]
Bug 35504: New cycle, new team :)
Comment 11 Martin Renvoize (ashimema) 2023-12-12 12:06:11 UTC
Created attachment 159731 [details] [review]
Bug 35504: Typo fix

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 12 Martin Renvoize (ashimema) 2023-12-12 12:06:14 UTC
Created attachment 159732 [details] [review]
Bug 35504: Corrections to team

Correction of 'advocate' to 'advocates' to ensure they appear in the
team.

Addition of 'website' and 'wiki' handling to ensure they also appear
in the team.
Comment 13 Martin Renvoize (ashimema) 2023-12-12 12:06:17 UTC
Created attachment 159733 [details] [review]
Bug 35504: Add ktd maintainer
Comment 14 Tomás Cohen Arazi (tcohen) 2023-12-15 20:42:35 UTC
Created attachment 159915 [details] [review]
Bug 35504: New cycle, new team :)

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 15 Tomás Cohen Arazi (tcohen) 2023-12-15 20:42:38 UTC
Created attachment 159916 [details] [review]
Bug 35504: Typo fix

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 16 Tomás Cohen Arazi (tcohen) 2023-12-15 20:42:43 UTC
Created attachment 159917 [details] [review]
Bug 35504: Corrections to team

Correction of 'advocate' to 'advocates' to ensure they appear in the
team.

Addition of 'website' and 'wiki' handling to ensure they also appear
in the team.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 17 Tomás Cohen Arazi (tcohen) 2023-12-15 20:42:46 UTC
Created attachment 159918 [details] [review]
Bug 35504: Add ktd maintainer

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 18 Lucas Gass (lukeg) 2024-01-03 14:34:51 UTC
Created attachment 160463 [details] [review]
Bug 35504: New cycle, new team :)

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 19 Lucas Gass (lukeg) 2024-01-03 14:34:53 UTC
Created attachment 160464 [details] [review]
Bug 35504: Typo fix

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 20 Lucas Gass (lukeg) 2024-01-03 14:34:55 UTC
Created attachment 160465 [details] [review]
Bug 35504: Corrections to team

Correction of 'advocate' to 'advocates' to ensure they appear in the
team.

Addition of 'website' and 'wiki' handling to ensure they also appear
in the team.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 21 Lucas Gass (lukeg) 2024-01-03 14:34:57 UTC
Created attachment 160466 [details] [review]
Bug 35504: Add ktd maintainer

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 22 Katrin Fischer 2024-01-05 14:50:16 UTC
I think we didn't get the wiki bit right, it currently still lists me (I haven't signed up :) ), and we are missing George Williams and Mason James, but we should have them.
Comment 23 Katrin Fischer 2024-01-05 14:52:56 UTC
Out of interest - how do the entries sort? I notice that it's not alphabetic, but also not following the sequence of the YAML file (for me RM is last QAM is first, but in the file RM would be first and QAM somehwere in the middle)
Comment 24 Martin Renvoize (ashimema) 2024-01-09 20:33:14 UTC
Ordering is in the template hard coded and it depends on whether your running a stable or dev branch.
Comment 25 David Nind 2024-01-09 21:32:05 UTC
A couple of things I noticed:

1. Under the 'Current maintenance team'
   - Wiki team: Mason James and George Williams to be added (already noted in comment #22), Katrin does so many updates to the Wiki - I think should be included 8-)
   - Release maintainers: These are not shown, not sure whether this role should be shown here or not (are listed under individual names in the 'Koha development team' section)
   - Continuous integration manager: Mason James not shown, not sure whether this role should be shown here or not (is listed under individual name in the 'Koha development team' section)

2. Under 'Koha development team' section:
   - Tomás Cohen Arazi: There is a bullet point then (24.05), assuming before that should be KTD maintainer
   - Frédéric Demians: Shows as Release Maintainer for 24.05 (not correct), should be 22.11 (LTS) *
   - Katrin Fischer: There is a bullet point then (23.05), not sure what that role should be for
   - Lucas Gass: Shows as Release Maintainer for 23.05 (correct), 23.11 (not correct), 24.05 (not correct) *
   - Andreas Hedström Mace: There is a bullet point then (20.05), not sure what that role should be for
   - Pedro Amorim, Agustín Moyano: Combined names for Topic expert (23.05)
   - Liz Rea: There is a bullet point then (23.05, 23.11, 24.05), assuming before that should be Website
   - Martin Renvoize: There is a bullet point then (23.05), not sure what that role should be for
   - Danyon Sewell: Shows as Release Maintainer for 23.11 (not correct) and 24.05 (not correct), should be 22.05 *
   - Fridolin Somers: Shows as Release Maintainer for 23.11 (correct) and 24.05 (not correct) *
   - Wainui Witika-Park: Shows as Release Maintainer for 21.11 (not checked), 22.05 (correct), 23.05 (not correct) *

* Not sure how release maintainers should be shown - release cycle or individual releases. I think it should be the individual release.
Comment 26 Martin Renvoize (ashimema) 2024-01-10 11:44:49 UTC
Created attachment 160752 [details] [review]
Bug 35504: New cycle, new team :)

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 27 Martin Renvoize (ashimema) 2024-01-10 11:44:52 UTC
Created attachment 160753 [details] [review]
Bug 35504: Typo fix

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 28 Martin Renvoize (ashimema) 2024-01-10 11:44:55 UTC
Created attachment 160754 [details] [review]
Bug 35504: Corrections to team

Correction of 'advocate' to 'advocates' to ensure they appear in the
team.

Addition of 'website' and 'wiki' handling to ensure they also appear
in the team.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 29 Martin Renvoize (ashimema) 2024-01-10 11:44:57 UTC
Created attachment 160755 [details] [review]
Bug 35504: Add ktd maintainer

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 30 Martin Renvoize (ashimema) 2024-01-10 11:45:00 UTC
Created attachment 160756 [details] [review]
Bug 35504: Corrections to wiki team
Comment 31 Martin Renvoize (ashimema) 2024-01-10 11:45:03 UTC
Created attachment 160757 [details] [review]
Bug 35504: Change 'Jenkins' to 'Continuous integration'

We were naming these roles differently between the 'current team' and
'past roles' display.
Comment 32 Martin Renvoize (ashimema) 2024-01-10 11:45:06 UTC
Created attachment 160758 [details] [review]
Bug 35504: Add full maintainers list into development branch

On a stable branch the current maintainer of your running version is
listed at the top of the current maintanence team.. however when you're
on a development branch the RM is responsible for your branch and the
maintainers were missing from display.

This patch adds the maintainers list back to the bottom of the current
maintanence team section, just for the development branch.
Comment 33 Martin Renvoize (ashimema) 2024-01-10 12:19:47 UTC
(In reply to David Nind from comment #25)
> A couple of things I noticed:
> 
> 1. Under the 'Current maintenance team'
>    - Wiki team: Mason James and George Williams to be added (already noted
> in comment #22), Katrin does so many updates to the Wiki - I think should be
> included 8-)

Fixed - I removed Katrin, but I agree, she does lots of Wiki stuff so I would have been happy to keep her too.

>    - Release maintainers: These are not shown, not sure whether this role
> should be shown here or not (are listed under individual names in the 'Koha
> development team' section)

This all depends on what Koha version you're looking at (i.e. a development checkout vs a stable branch).  For a stable branch the maintainer for the version your on will appear at the top.. for a development one the maintainers list wasn't appearing at all.. I've added  a patch to get them to appear for the development channel too.

>    - Continuous integration manager: Mason James not shown, not sure whether
> this role should be shown here or not (is listed under individual name in
> the 'Koha development team' section)

It was listed as 'Jenkins'.. I've updated the term to match what we call it in the lower section.

> 2. Under 'Koha development team' section:
Looking at these one's now.
Comment 34 Martin Renvoize (ashimema) 2024-01-10 13:49:53 UTC
Created attachment 160764 [details] [review]
Bug 35504: Split list of ERM Topic experts
Comment 35 Martin Renvoize (ashimema) 2024-01-10 13:49:55 UTC
Created attachment 160765 [details] [review]
Bug 35504: Distinguish different RMaint and Topic Expert roles

This patch further splits up release maintanence and topic expert roles
so that they display with further, more accurate, detail in the
development team section.
Comment 36 Martin Renvoize (ashimema) 2024-01-10 13:51:11 UTC
Last two patches should deal with the rest of the issues David highlighted.. thanks for testing.
Comment 37 Martin Renvoize (ashimema) 2024-01-10 13:56:41 UTC
Created attachment 160766 [details]
How it all looks now
Comment 38 Katrin Fischer 2024-01-11 14:50:00 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 39 Fridolin Somers 2024-01-15 14:24:42 UTC
Pushed to 23.11.x for 23.11.02
Comment 40 Lucas Gass (lukeg) 2024-02-02 16:18:06 UTC
Backported to 23.05.x for upcoming 23.05.09