| Summary: | Terminology: Bookseller in basket group CSV export | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Templates | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | fridolin.somers, lucas, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.02
|
|
| Circulation function: | |||
| Attachments: |
Bug 35524: Fix terminology in basket group CSV export
Bug 35524: Fix terminology in basket group CSV export Bug 35524: Fix terminology in basket group CSV export Bug 35524: Fix terminology in basket group CSV export |
||
|
Description
Katrin Fischer
2023-12-10 13:28:40 UTC
Created attachment 159696 [details] [review] Bug 35524: Fix terminology in basket group CSV export Bookseller should be vendor to match our preferred terminology. To test: * Run: prove t/db_dependent/Acquisition/GetBasketGroupAsCSV.t * Add a basket with at least one order line * Close basket and add to a basket group * Close the basket group * Export as CSV * Verify headers include "Bookseller" * Apply patch, restart all * Repeat export, it should now say "Vendor" * Rerun tests Created attachment 159706 [details] [review] Bug 35524: Fix terminology in basket group CSV export Bookseller should be vendor to match our preferred terminology. To test: * Run: prove t/db_dependent/Acquisition/GetBasketGroupAsCSV.t * Add a basket with at least one order line * Close basket and add to a basket group * Close the basket group * Export as CSV * Verify headers include "Bookseller" * Apply patch, restart all * Repeat export, it should now say "Vendor" * Rerun tests Signed-off-by: David Nind <david@davidnind.com> Created attachment 159950 [details] [review] Bug 35524: Fix terminology in basket group CSV export Bookseller should be vendor to match our preferred terminology. To test: * Run: prove t/db_dependent/Acquisition/GetBasketGroupAsCSV.t * Add a basket with at least one order line * Close basket and add to a basket group * Close the basket group * Export as CSV * Verify headers include "Bookseller" * Apply patch, restart all * Repeat export, it should now say "Vendor" * Rerun tests Signed-off-by: David Nind <david@davidnind.com> Created attachment 159951 [details] [review] Bug 35524: Fix terminology in basket group CSV export Bookseller should be vendor to match our preferred terminology. To test: * Run: prove t/db_dependent/Acquisition/GetBasketGroupAsCSV.t * Add a basket with at least one order line * Close basket and add to a basket group * Close the basket group * Export as CSV * Verify headers include "Bookseller" * Apply patch, restart all * Repeat export, it should now say "Vendor" * Rerun tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.02 Doesn't apply cleanly in 23.05.x, no backport. |