Bug 35524

Summary: Terminology: Bookseller in basket group CSV export
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: TemplatesAssignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Tomás Cohen Arazi (tcohen) <tomascohen>
Severity: trivial    
Priority: P5 - low CC: fridolin.somers, lucas, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02
Circulation function:
Attachments: Bug 35524: Fix terminology in basket group CSV export
Bug 35524: Fix terminology in basket group CSV export
Bug 35524: Fix terminology in basket group CSV export
Bug 35524: Fix terminology in basket group CSV export

Description Katrin Fischer 2023-12-10 13:28:40 UTC

    
Comment 1 Katrin Fischer 2023-12-10 13:34:03 UTC
Created attachment 159696 [details] [review]
Bug 35524: Fix terminology in basket group CSV export

Bookseller should be vendor to match our preferred terminology.

To test:
* Run:
  prove t/db_dependent/Acquisition/GetBasketGroupAsCSV.t
* Add a basket with at least one order line
* Close basket and add to a basket group
* Close the basket group
* Export as CSV
* Verify headers include "Bookseller"
* Apply patch, restart all
* Repeat export, it should now say "Vendor"
* Rerun tests
Comment 2 David Nind 2023-12-11 09:23:31 UTC
Created attachment 159706 [details] [review]
Bug 35524: Fix terminology in basket group CSV export

Bookseller should be vendor to match our preferred terminology.

To test:
* Run:
  prove t/db_dependent/Acquisition/GetBasketGroupAsCSV.t
* Add a basket with at least one order line
* Close basket and add to a basket group
* Close the basket group
* Export as CSV
* Verify headers include "Bookseller"
* Apply patch, restart all
* Repeat export, it should now say "Vendor"
* Rerun tests

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Tomás Cohen Arazi (tcohen) 2023-12-18 11:42:39 UTC Comment hidden (obsolete)
Comment 4 Tomás Cohen Arazi (tcohen) 2023-12-18 11:44:56 UTC
Created attachment 159951 [details] [review]
Bug 35524: Fix terminology in basket group CSV export

Bookseller should be vendor to match our preferred terminology.

To test:
* Run:
  prove t/db_dependent/Acquisition/GetBasketGroupAsCSV.t
* Add a basket with at least one order line
* Close basket and add to a basket group
* Close the basket group
* Export as CSV
* Verify headers include "Bookseller"
* Apply patch, restart all
* Repeat export, it should now say "Vendor"
* Rerun tests

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Katrin Fischer 2023-12-18 14:25:42 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-01-03 14:22:34 UTC
Pushed to 23.11.x for 23.11.02
Comment 7 Lucas Gass (lukeg) 2024-01-04 20:15:01 UTC
Doesn't apply cleanly in 23.05.x, no backport.