Bug 35529

Summary: Avoid 'click' for links in library administration
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: TemplatesAssignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Julian Maurice <julian.maurice>
Severity: trivial    
Priority: P5 - low CC: fridolin.somers, julian.maurice, lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02
Circulation function:
Bug Depends on:    
Bug Blocks: 35527    
Attachments: Bug 35529: Avoid 'click' in link in library administration
Bug 35529: Avoid 'click' in link in library administration
Bug 35529: Avoid 'click' in link in library administration

Description Katrin Fischer 2023-12-10 15:08:43 UTC

    
Comment 1 Katrin Fischer 2023-12-10 15:19:00 UTC Comment hidden (obsolete)
Comment 2 David Nind 2023-12-11 09:54:21 UTC
Created attachment 159709 [details] [review]
Bug 35529: Avoid 'click' in link in library administration

It's not necessary to label a link with 'click', it being
a link and being formatted as such is enough.

To test:
* Go to administration > libraries
* Edit any library
* Verify link texts for UserCSS and UserJS
  * Click to edit
  * Click to collapse
* Apply patch, restart all
* Verify links have been updated, click removed

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Julian Maurice 2023-12-21 10:51:14 UTC
Created attachment 160190 [details] [review]
Bug 35529: Avoid 'click' in link in library administration

It's not necessary to label a link with 'click', it being
a link and being formatted as such is enough.

To test:
* Go to administration > libraries
* Edit any library
* Verify link texts for UserCSS and UserJS
  * Click to edit
  * Click to collapse
* Apply patch, restart all
* Verify links have been updated, click removed

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 4 Katrin Fischer 2023-12-27 18:10:18 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-01-03 15:34:30 UTC
Pushed to 23.11.x for 23.11.02
Comment 6 Lucas Gass (lukeg) 2024-01-04 21:02:23 UTC
Doesn't apply clean to 23.05.x, no backport.