Bug 35541

Summary: Chosen renewal due date not respected when we override limit
Product: Koha Reporter: Noémie Labine <noemie.labine>
Component: CirculationAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: gmcharlt, koha, kyle.m.hall
Version: 23.05   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Noémie Labine 2023-12-11 19:46:13 UTC
When an item has been renewed the maximum number of times, we can override the limit if AllowRenewalLimitOverride says Allow.

But if we try to renew the item from the circulation module and we manually choose a new due date, this date is not respected and the due date will follow the circulation rules for the item instead.

Test plan :
1. Checkout an item and renew it the maximum number of times
2. when there are no more renewals, go to circulation module and manually choose a due date to renew the item.
3. You'll get the cannot renew message asking if you want to override and renew or cancel. Override and renew the item. The new due date is not the date we chose but the date chosen by the circulation rules.


Note that if we try to override the renewal limit and chose a new due date directly in the patron's record, the chosen date will be respected after the override.
Comment 1 Katrin Fischer 2023-12-30 19:43:54 UTC
Hi, what do you mean by "circulation module" - the renew page or the patron account or both?
Comment 2 Noémie Labine 2024-03-21 19:04:28 UTC
hi Katrin,

I mean the renew page.

If we override the renewal restrictions and choose a due date manually in the patron's account, this date is respected.

But in the renew page, if I choose a renewal date, then confirm that I want to override the restriction, then the date I chose is not respected.
Comment 3 Noémie Labine 2024-03-21 19:04:41 UTC
still valid in 23.05