Summary: | Show new issue status in subscription tab in OPAC and staff detail pages | ||
---|---|---|---|
Product: | Koha | Reporter: | Kelly McElligott <kelly> |
Component: | Serials | Assignee: | Bugs List <koha-bugs> |
Status: | NEW --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 32752 | ||
Bug Blocks: |
Description
Kelly McElligott
2023-12-18 19:25:27 UTC
Hm, that's a bit of an odd one, because they should be showing in way more places. If you look at the test plans of 32752, it should show: Staff interface: * Subscription detail page > issues tab * Catalog detail page > subscription tab * Serial claims page * Serial collection page of your subscription And OPAC: * Subscription tab * More details > Full history displays the status nicely too They don't show in the holdings, because it's not an item status, but a status of the serial issue. Other issue status don't show there either. Hm, I just gave this a quick test and things still seem to work as expected, but the problem here is not a display one: It's a data selection problem. For the display on the subscription tab the issues are filtered by status before they hit the template. It will only ever show arrived or missing status (seems a bit of a peculiar selection?) So I think we'd need to agree on how to change it and which status should show or maybe make it configurable? From looking at the code: GetLatestSerials is used: =head2 GetLatestSerials \@serials = GetLatestSerials($subscriptionid,$limit) get the $limit's latest serials arrived or missing for a given subscription return : a ref to an array which contains all of the latest serials stored into a hash. =cut sub GetLatestSerials { my ( $subscriptionid, $limit ) = @_; return unless ($subscriptionid and $limit); my $dbh = C4::Context->dbh; my $statuses = join( ',', ( ARRIVED, MISSING_STATUSES ) ); my $strsth = "SELECT serialid,serialseq, status, planneddate, publisheddate, publisheddatetext, notes FROM serial WHERE subscriptionid = ? AND status IN ($statuses) ORDER BY publisheddate DESC LIMIT 0,$limit "; my $sth = $dbh->prepare($strsth); $sth->execute($subscriptionid); my @serials; while ( my $line = $sth->fetchrow_hashref ) { $line->{ "status" . $line->{status} } = 1; # fills a "statusX" value, used for template status select list push @serials, $line; } return \@serials; } oh yes, sorry Katrin! I didn't mean the holdings tab! All good, I just needed to work through it for myself, because I had thought I caught all the important places. But I think you are right, having it show up on the subscriptions tab would be nice! I am just not sure if I dare to change that old piece of code myself with unit tests and all. I think it might be desirable to configure different status list for staff interface and OPAC, but then we'll also need to pass the interface. |