|
Description
Tomás Cohen Arazi (tcohen)
2023-12-20 13:56:42 UTC
Updating using `cpanm` pulled JSON::Validator@5.14 and everything seems fine with the tests. Created attachment 160117 [details] [review] Bug 35614: Update cpanfile for Mojolicious::Plugin::OpenAPI v5.09 This patch updates the following libraries, as required by Koha: * Mojolicious::Plugin::OpenAPI * JSON::Validator To test: 1. Apply this patch 2. Run: $ ktd --shell k$ sudo cpanm --installdeps . => SUCCESS: Dependencies updated correctly 3. Run: k$ prove -r t/db_dependent/api/v1/ \ t/db_dependent/Koha/REST/ => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 160192 [details] [review] Bug 35614: Update cpanfile for Mojolicious::Plugin::OpenAPI v5.09 This patch updates the following libraries, as required by Koha: * Mojolicious::Plugin::OpenAPI * JSON::Validator To test: 1. Apply this patch 2. Run: $ ktd --shell k$ sudo cpanm --installdeps . => SUCCESS: Dependencies updated correctly 3. Run: k$ prove -r t/db_dependent/api/v1/ \ t/db_dependent/Koha/REST/ => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Why is it required to increase the minimum version for these two modules ? We were having a weird error on a spec regarding collectionFormat and we noticed https://github.com/jhthorsen/mojolicious-plugin-openapi/commit/c972fdd02a05dc635257715a4b8c541b218e2817 Because after updating the updated library the problem went away. To reproduce: 1. Point your REST client to /api/v1/holds 2. Pass x-koha-embed: pickup_library => SUCCESS: You get the results 3. Pass x-koha-embed: biblio => SUCCSS: You get results 4. Pass x-koha-embed: pickup_library,biblio => FAIL: Weird and inconsistent error (i.e. it tells you valid options are... what we passed) 5. Update the library 6. Repeat 4 => SUCCESS: It now works What does it mean for the package manager? We need more info here. libjson-validator-perl
buster (oldoldstable) 3.06+dfsg-1: all
bullseye (oldstable) 4.14+dfsg-1: all
bookworm (stable) 5.14+dfsg-1: all
trixie (testing) 5.14+dfsg-1: all
sid (unstable) 5.14+dfsg-1: all
focal (20.04LTS) 3.23+dfsg-1: all
jammy (22.04LTS) 5.05+dfsg-1: all
lunar (23.04) 5.13+dfsg-1: all
mantic (23.10) 5.14+dfsg-1: all
libmojolicious-plugin-openapi-perl
bullseye (oldstable) 3.41-1: all
bookworm (stable) 5.09-1: all
trixie (testing) 5.09-1: all
sid (unstable) 5.09-1: all
focal (20.04LTS) 2.21-1: all
jammy (22.04LTS) 5.02-1: all
lunar (23.04) 5.09-1: all
mantic (23.10) 5.09-1: all
So we still need to package our own.
Mason, are you ok with that? We would need to remove the '-really' and provide JSON::Validator 5.14 and Mojolicious::Plugin::OpenAPI 5.09
Ping We need to move forward here. ping Mason! Created attachment 164116 [details] [review] Bug 35614: Update cpanfile for Mojolicious::Plugin::OpenAPI v5.09 This patch updates the following libraries, as required by Koha: * Mojolicious::Plugin::OpenAPI * JSON::Validator To test: 1. Apply this patch 2. Run: $ ktd --shell k$ sudo cpanm --installdeps . => SUCCESS: Dependencies updated correctly 3. Run: k$ prove -r t/db_dependent/api/v1/ \ t/db_dependent/Koha/REST/ => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> (In reply to Jonathan Druart from comment #7) > So we still need to package our own. > > Mason, are you ok with that? We would need to remove the '-really' and > provide JSON::Validator 5.14 and Mojolicious::Plugin::OpenAPI 5.09 No need to keep this in SO. Mason, please respond or update our packages accordingly. (In reply to Marcel de Rooy from comment #11) > (In reply to Jonathan Druart from comment #7) > > So we still need to package our own. > > > > Mason, are you ok with that? We would need to remove the '-really' and > > provide JSON::Validator 5.14 and Mojolicious::Plugin::OpenAPI 5.09 > > No need to keep this in SO. > Mason, please respond or update our packages accordingly. Ok but then now it's PQA whereas it's not ready for push because we are waiting for Mason's feedback? I've pinged Mason about this one. (In reply to Marcel de Rooy from comment #11) > (In reply to Jonathan Druart from comment #7) > > So we still need to package our own. > > > > Mason, are you ok with that? We would need to remove the '-really' and > > provide JSON::Validator 5.14 and Mojolicious::Plugin::OpenAPI 5.09 > > No need to keep this in SO. > Mason, please respond or update our packages accordingly. hi Marcel, i've updated the packages in the staging repo i've had to keep the '+really' suffix, so existing packages will be correctly updated Created attachment 164403 [details] [review] Bug 35614: Update cpanfile for Mojolicious::Plugin::OpenAPI v5.09 This patch updates the following libraries, as required by Koha: * Mojolicious::Plugin::OpenAPI * JSON::Validator To test: 1. Apply this patch 2. Run: $ ktd --shell k$ sudo cpanm --installdeps . => SUCCESS: Dependencies updated correctly 3. Run: k$ prove -r t/db_dependent/api/v1/ \ t/db_dependent/Koha/REST/ => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mason James <mtj@kohaaloha.com> Pushed for 24.05! Well done everyone, thank you! Is this needed for backport ? |