Summary: | Long SMS messages are not sent if they exceed the character limitation of the messaging driver | ||
---|---|---|---|
Product: | Koha | Reporter: | Emily-Rose Francoeur <emily-rose.francoeur> |
Component: | Notices | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | Needs documenting --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, emily-rose.francoeur, kyle, lucas, martin.renvoize, matthias.le-gac, philippe.blouin |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
24.11.00
|
Circulation function: | |
Attachments: |
Bug 35639: Trim the messages that are too long before sending them via SMS
Bug 35639: Trim the messages that are too long before sending them via SMS Bug 35639: Trim the messages that are too long before sending them via SMS Bug 35639: Trim the messages that are too long before sending them via SMS |
Description
Emily-Rose Francoeur
2023-12-22 13:19:21 UTC
Created attachment 160243 [details] [review] Bug 35639: Trim the messages that are too long before sending them via SMS I created a new system preference, SMSSendMaxChar, which allows you to set a limit for the number of characters in SMS messages to send. When a limit is set, messages that exceed it will be trimed. TEST PLAN 1) Apply the patch 2) Run prove t/db_dependent/Letters.t Created attachment 160684 [details] [review] Bug 35639: Trim the messages that are too long before sending them via SMS I created a new system preference, SMSSendMaxChar, which allows you to set a limit for the number of characters in SMS messages to send. When a limit is set, messages that exceed it will be trimed. TEST PLAN 1) Apply the patch 2) Run prove t/db_dependent/Letters.t Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Created attachment 164486 [details] [review] Bug 35639: Trim the messages that are too long before sending them via SMS I created a new system preference, SMSSendMaxChar, which allows you to set a limit for the number of characters in SMS messages to send. When a limit is set, messages that exceed it will be trimed. TEST PLAN 1) Apply the patch 2) Run prove t/db_dependent/Letters.t Created attachment 166887 [details] [review] Bug 35639: Trim the messages that are too long before sending them via SMS I created a new system preference, SMSSendMaxChar, which allows you to set a limit for the number of characters in SMS messages to send. When a limit is set, messages that exceed it will be trimed. TEST PLAN 1) Apply the patch 2) Run prove t/db_dependent/Letters.t Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Would it not be more effective to split the message into chunks of SMSSendMaxChar characters and send multiple messages at the time of sending, rather than truncating the message at the time it is enqueued? It would cost more for the libraries though, since SMS are usually an amount per message sent, no? (In reply to Caroline Cyr La Rose from comment #6) > It would cost more for the libraries though, since SMS are usually an amount > per message sent, no? I think that's correct. (In reply to Katrin Fischer from comment #7) > (In reply to Caroline Cyr La Rose from comment #6) > > It would cost more for the libraries though, since SMS are usually an amount > > per message sent, no? > > I think that's correct. Sounds reasonable. Thanks for the feedback! Could we somehow highlight to the template author the need to reduce character counts in SMS notice templates too? Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant Re-opening as the new SMSSendMaxChar system preference needs to be added to the Koha Manual. |