Summary: | Toggle for advanced editor should not show to staff without advanced_editor permissions | ||
---|---|---|---|
Product: | Koha | Reporter: | Kelly McElligott <kelly> |
Component: | Cataloging | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, fridolin.somers, lucas, m.de.rooy, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the display of the button to access the advanced editor. It now only displays when the staff patron has the correct permissions ("Use the advanced cataloging editor (requires edit_catalogue)").
|
Version(s) released in: |
24.05.00,23.11.02
|
Circulation function: | |||
Bug Depends on: | 34275 | ||
Bug Blocks: | |||
Attachments: |
Bug 35651: Add check to make sure user has advanced_editor permission
Bug 35651: Add check to make sure user has advanced_editor permission Bug 35651: Add check to make sure user has advanced_editor permission |
Description
Kelly McElligott
2023-12-26 15:37:40 UTC
Created attachment 160326 [details] [review] Bug 35651: Add check to make sure user has advanced_editor permission To test: 1. Turn on the system preference 'EnableAdvancedCatalogingEditor'. 2. Set up a staff user with permissions to editcatlouge but make sure "Use the advanced cataloging editor (requires edit_catalogue)" if OFF. 3. Log in as that patron. 4. Go to a record or create a new one in the basic editor and see the toggle advanced editor button. 5. Try toggling it and you are logged out. 6. APPLY PATCH 7. Try 3 & 4 again, this time there should be no toggle button. 8. Log in as a patron who does havbe the "Use the advanced cataloging editor (requires edit_catalogue)" permission on. They should be able to toggle between editors. Created attachment 160327 [details] [review] Bug 35651: Add check to make sure user has advanced_editor permission To test: 1. Turn on the system preference 'EnableAdvancedCatalogingEditor'. 2. Set up a staff user with permissions to editcatlouge but make sure "Use the advanced cataloging editor (requires edit_catalogue)" if OFF. 3. Log in as that patron. 4. Go to a record or create a new one in the basic editor and see the toggle advanced editor button. 5. Try toggling it and you are logged out. 6. APPLY PATCH 7. Try 3 & 4 again, this time there should be no toggle button. 8. Log in as a patron who does havbe the "Use the advanced cataloging editor (requires edit_catalogue)" permission on. They should be able to toggle between editors. Signed-off-by: Kelly <kelly@bywatersolutions.com> Hi Kelly! Could you update the status to signed off? (Then you will get the credit on the dashboard!) David Created attachment 161051 [details] [review] Bug 35651: Add check to make sure user has advanced_editor permission To test: 1. Turn on the system preference 'EnableAdvancedCatalogingEditor'. 2. Set up a staff user with permissions to editcatlouge but make sure "Use the advanced cataloging editor (requires edit_catalogue)" if OFF. 3. Log in as that patron. 4. Go to a record or create a new one in the basic editor and see the toggle advanced editor button. 5. Try toggling it and you are logged out. 6. APPLY PATCH 7. Try 3 & 4 again, this time there should be no toggle button. 8. Log in as a patron who does havbe the "Use the advanced cataloging editor (requires edit_catalogue)" permission on. They should be able to toggle between editors. Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Works, makes sense, QA script happy, code looks good, passing QA :) Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.02 |