Summary: | Case missing from installer step 3 template title | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Installation and upgrade (web-based installer) | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Lucas Gass (lukeg) <lucas> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, fridolin.somers, gmcharlt, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/installer/install.pl?step=3&op=updatestructure | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes a web browser page title for the web installer - from " > Web installer > Koha" to "Updating database structure > Web installer > Koha".
|
Version(s) released in: |
24.05.00,23.11.02
|
Circulation function: | |||
Attachments: |
Bug 35686: Case missing from installer step 3 template title
Bug 35686: Case missing from installer step 3 template title Bug 35686: (follow-up) Correct page heading Bug 35686: Case missing from installer step 3 template title Bug 35686: (follow-up) Correct page heading |
Description
Owen Leonard
2024-01-03 13:07:34 UTC
Created attachment 160467 [details] [review] Bug 35686: Case missing from installer step 3 template title This patch adds a missing case to the display of the title on step 3 of the web installer. This resulted in an empty first part of the title: " > Web installer > Koha" To test, apply the patch and reset the database version from the command line in Koha Testing Docker: > koha-mysql kohadev > UPDATE systempreferences SET value = '23.1200002 WHERE variable = 'version'; > quit > Restart all - Go to the staff interface. You should be taken to the web installer. - Log in to the web installer and proceed through until you get to the "Updating database structure" page. - Confirm that the page title is correct. Created attachment 160593 [details] [review] Bug 35686: Case missing from installer step 3 template title This patch adds a missing case to the display of the title on step 3 of the web installer. This resulted in an empty first part of the title: " > Web installer > Koha" To test, apply the patch and reset the database version from the command line in Koha Testing Docker: > koha-mysql kohadev > UPDATE systempreferences SET value = '23.1200002 WHERE variable = 'version'; > quit > Restart all - Go to the staff interface. You should be taken to the web installer. - Log in to the web installer and proceed through until you get to the "Updating database structure" page. - Confirm that the page title is correct. Signed-off-by: David Nind <david@davidnind.com> Does the title displayed on the page need updating as well? Most pages have this title pattern, for example: Web installer › Update database On the page that this bug fixes, the page title is just: Updating database structure Should this be: Web installer › Updating database structure Testing notes using KTD: 1. I used this statement to update the version: UPDATE systempreferences SET value = '23.1200000' WHERE variable = 'version'; 2. Restart everything: restart_all 3. Go to the staff interface 4. Upgrade starts - Use koha_kohadev as the user and password as the password - Grant more privileges to the koha_kohadev user: . mysql -uroot -ppassword -hkoha-db-1 . use mysql . grant all on koha_kohadev.* to koha_kohadev; . flush privileges; Created attachment 160627 [details] [review] Bug 35686: (follow-up) Correct page heading Straightforward and simple fixes, no issues with the QA tool. Created attachment 160677 [details] [review] Bug 35686: Case missing from installer step 3 template title This patch adds a missing case to the display of the title on step 3 of the web installer. This resulted in an empty first part of the title: " > Web installer > Koha" To test, apply the patch and reset the database version from the command line in Koha Testing Docker: > koha-mysql kohadev > UPDATE systempreferences SET value = '23.1200002 WHERE variable = 'version'; > quit > Restart all - Go to the staff interface. You should be taken to the web installer. - Log in to the web installer and proceed through until you get to the "Updating database structure" page. - Confirm that the page title is correct. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 160678 [details] [review] Bug 35686: (follow-up) Correct page heading Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.02 Merge conflicts with 23.05.x, no backport. |