Bug 35696

Summary: Transit status not properly updated for items advanced in Stock Rotation tool
Product: Koha Reporter: Heather Rommens <heather>
Component: ToolsAssignee: Martin Renvoize (ashimema) <martin.renvoize>
Status: Pushed to oldstable --- QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: fridolin.somers, lucas, rcoert
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02,23.05.08
Circulation function:
Bug Depends on: 33167    
Bug Blocks: 35934    
Attachments: Transit status of stock rotation items 23.05.06
Bug 35696: Fix regression caused by bug 33167
Bug 35696: Fix regression caused by bug 33167
Bug 35696: Fix regression caused by bug 33167

Description Heather Rommens 2024-01-03 22:57:41 UTC
Created attachment 160507 [details]
Transit status of stock rotation items 23.05.06

While using the stock rotation tool in the Cataloging module, when items in rotas are advanced to the next stage, the status is not updating properly. In a proper status update for advancing items, the status reads "Transit pending from XX branch to YY branch since mm/dd/yyyy" which displays in 22.11.10. In 23.05.06, the status updates to show "Transit is pending from XX branch to YY branch since Available".
Comment 1 Martin Renvoize (ashimema) 2024-01-04 16:28:45 UTC
Created attachment 160548 [details] [review]
Bug 35696: Fix regression caused by bug 33167

A case was missed when switching from item.transfer.field to just
transfer.field.

This meant that the daterequested date wasn't getting filled properly in
the UI.
Comment 2 Martin Renvoize (ashimema) 2024-01-04 16:29:50 UTC
Created attachment 160549 [details] [review]
Bug 35696: Fix regression caused by bug 33167

A case was missed when switching from item.transfer.field to just
transfer.field.

This meant that the daterequested date wasn't getting filled properly in
the UI.
Comment 3 Martin Renvoize (ashimema) 2024-01-04 16:31:30 UTC
This is affecting all pending transfers.. it's just that stockrotation is the most obvious case where an item can be pending but not in transit.

It's caused by bug 33167
Comment 4 Lucas Gass (lukeg) 2024-01-04 16:43:44 UTC
Fix works good and is trivial. I think this can go straight PQA, let's get this fix in asap!
Comment 5 Lucas Gass (lukeg) 2024-01-04 16:44:19 UTC
Created attachment 160550 [details] [review]
Bug 35696: Fix regression caused by bug 33167

A case was missed when switching from item.transfer.field to just
transfer.field.

This meant that the daterequested date wasn't getting filled properly in
the UI.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 6 Katrin Fischer 2024-01-05 13:08:17 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-01-08 14:35:14 UTC
Pushed to 23.11.x for 23.11.02
Comment 8 Lucas Gass (lukeg) 2024-01-12 22:25:45 UTC
Backported to 23.05.x for upcoming 23.05.08