Summary: | Reduce DB calls when performing authorities merge | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Architecture, internals, and plumbing | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, lucas, mengu, wainuiwitikapark |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
24.05.00,23.11.02,23.05.09,22.11.28
|
Circulation function: | |
Attachments: |
Bug 35702: Use framework code from biblio object
Bug 35702: Fetch biblios at once and loop Bug 35702: Use framework code from biblio object Bug 35702: Fetch biblios at once and loop Bug 35702: Use framework code from biblio object Bug 35702: Fetch biblios at once and loop |
Description
Nick Clemens (kidclamp)
2024-01-04 15:13:09 UTC
Created attachment 160537 [details] [review] Bug 35702: Use framework code from biblio object Created attachment 160538 [details] [review] Bug 35702: Fetch biblios at once and loop Test plan: prove -v t/db_dependent/Authority/Merge.t Created attachment 160596 [details] [review] Bug 35702: Use framework code from biblio object Signed-off-by: David Nind <david@davidnind.com> Created attachment 160597 [details] [review] Bug 35702: Fetch biblios at once and loop Test plan: prove -v t/db_dependent/Authority/Merge.t Signed-off-by: David Nind <david@davidnind.com> Created attachment 160900 [details] [review] Bug 35702: Use framework code from biblio object Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 160901 [details] [review] Bug 35702: Fetch biblios at once and loop Test plan: prove -v t/db_dependent/Authority/Merge.t Signed-off-by: David Nind <david@davidnind.com> Amended-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Replace $biblio->id with $biblio->biblionumber Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> I have replaced $biblio->id with $biblio->biblionumber. I don't think we should add confusion (especially for newcomers) and use both id and biblionumber. If we want to move to id we can have a vote and decide. But that's not a discussion for here nor now. Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.02 Backported to 23.05.x for upcoming 23.05.09 Applied to 22.11 for 22.11.28 |