| Summary: | Unused code in HoldsQueue::MapItemsToHoldRequests | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andreas Jonsson <andreas.jonsson> |
| Component: | Hold requests | Assignee: | Andreas Jonsson <andreas.jonsson> |
| Status: | Needs documenting --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: |
24.05.00
|
Circulation function: | |
| Attachments: |
Bug 35727 Remove unused code in HoldsQueue::MapItemsToHoldRequests
Bug 35727 Remove unused code in HoldsQueue::MapItemsToHoldRequests Bug 35727 Remove unused code in HoldsQueue::MapItemsToHoldRequests |
||
Created attachment 160652 [details] [review] Bug 35727 Remove unused code in HoldsQueue::MapItemsToHoldRequests Test plan: prove t/db_dependent/HoldsQueue.t Created attachment 160664 [details] [review] Bug 35727 Remove unused code in HoldsQueue::MapItemsToHoldRequests Test plan: prove t/db_dependent/HoldsQueue.t Signed-off-by: David Nind <david@davidnind.com> Created attachment 165081 [details] [review] Bug 35727 Remove unused code in HoldsQueue::MapItemsToHoldRequests Test plan: prove t/db_dependent/HoldsQueue.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 24.05! Well done everyone, thank you! Not backported to 23.11.x |
The hash %specific_items_requested is computed but never used anywhere. I went all the way back to v3.0.6 and couldn't find any sign that it has ever been used. # identify item-level requests my %specific_items_requested = map { $_->{itemnumber} => 1 } grep { defined($_->{itemnumber}) } @$hold_requests;