Bug 35727

Summary: Unused code in HoldsQueue::MapItemsToHoldRequests
Product: Koha Reporter: Andreas Jonsson <andreas.jonsson>
Component: Hold requestsAssignee: Andreas Jonsson <andreas.jonsson>
Status: Needs documenting --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, gmcharlt, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00
Attachments: Bug 35727 Remove unused code in HoldsQueue::MapItemsToHoldRequests
Bug 35727 Remove unused code in HoldsQueue::MapItemsToHoldRequests
Bug 35727 Remove unused code in HoldsQueue::MapItemsToHoldRequests

Description Andreas Jonsson 2024-01-08 16:56:37 UTC
The hash %specific_items_requested is computed but never used anywhere.  I went all the way back to v3.0.6 and couldn't find any sign that it has ever been used.


    # identify item-level requests
    my %specific_items_requested = map { $_->{itemnumber} => 1 }
                                   grep { defined($_->{itemnumber}) }
                                   @$hold_requests;
Comment 1 Andreas Jonsson 2024-01-08 17:00:58 UTC
Created attachment 160652 [details] [review]
Bug 35727 Remove unused code in HoldsQueue::MapItemsToHoldRequests

Test plan:

prove t/db_dependent/HoldsQueue.t
Comment 2 David Nind 2024-01-08 21:42:23 UTC
Created attachment 160664 [details] [review]
Bug 35727 Remove unused code in HoldsQueue::MapItemsToHoldRequests

Test plan:

prove t/db_dependent/HoldsQueue.t

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2024-04-18 12:00:50 UTC
Created attachment 165081 [details] [review]
Bug 35727 Remove unused code in HoldsQueue::MapItemsToHoldRequests

Test plan:

prove t/db_dependent/HoldsQueue.t

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2024-04-29 07:38:20 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-05-24 09:43:24 UTC
Not backported to 23.11.x