Summary: | Implement +strings for GET /patrons/:patron_id | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | REST API | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, lucas, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.03
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 35745 | ||
Attachments: |
Bug 35744: Implement +strings for GET /patrons/:patron_id
Bug 35744: Implement +strings for GET /patrons/:patron_id Bug 35744: Implement +strings for GET /patrons/:patron_id |
Description
Jonathan Druart
2024-01-09 13:50:36 UTC
Created attachment 160696 [details] [review] Bug 35744: Implement +strings for GET /patrons/:patron_id In order to retrieve the library's name and patron category's description alongwith other patron's info. Test plan: Run the following command before and after this patch: % curl -u koha:koha --request GET 'http://localhost:8081/api/v1/patrons/42' --header "Content-Type: application/json" --header "x-koha-embed: +strings" | jq Notice that you now have _strings which contains the library's name and patron category's description Created attachment 160712 [details] [review] Bug 35744: Implement +strings for GET /patrons/:patron_id In order to retrieve the library's name and patron category's description alongwith other patron's info. Test plan: Run the following command before and after this patch: % curl -u koha:koha --request GET 'http://localhost:8081/api/v1/patrons/42' --header "Content-Type: application/json" --header "x-koha-embed: +strings" | jq Notice that you now have _strings which contains the library's name and patron category's description Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 161088 [details] [review] Bug 35744: Implement +strings for GET /patrons/:patron_id In order to retrieve the library's name and patron category's description alongwith other patron's info. Test plan: Run the following command before and after this patch: % curl -u koha:koha --request GET 'http://localhost:8081/api/v1/patrons/42' --header "Content-Type: application/json" --header "x-koha-embed: +strings" | jq Notice that you now have _strings which contains the library's name and patron category's description Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> The code works, is tested and passed QA (after I did a small tidy on the new code section added). I'm passing QA.. but... What pushed you toward the choice of using +strings here vs just an embed? Whilst it does reduce a small amount of data down the line, the db queries will be the same I believe.. so I'm not sure what the decision making process was? (In reply to Martin Renvoize from comment #4) > What pushed you toward the choice of using +strings here vs just an embed? > Whilst it does reduce a small amount of data down the line, the db queries > will be the same I believe.. so I'm not sure what the decision making > process was? I had to pick one of the two options and choose this one :) Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.03 |