Bug 35752

Summary:	Can't delete additional contents with 'Delete selected' button
Product:	Koha	Reporter:	Lucas Gass (lukeg) <lucas>
Component:	Staff interface	Assignee:	Lucas Gass (lukeg) <lucas>
Status:	Pushed to stable ---	QA Contact:	Victor Grousset/tuxayo <victor>
Severity:	normal
Priority:	P5 - low	CC:	david, fridolin.somers, gmcharlt, jonathan.druart, victor
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	24.05.00,23.11.03
Circulation function:
Bug Depends on:	34368
Bug Blocks:	35753
Attachments:	Bug 35752: Pass CSRF token to del_form Bug 35752: Pass CSRF token to del_form Bug 35752: Pass CSRF token to del_form

Description Lucas Gass (lukeg) 2024-01-09 21:46:06 UTC

Comment 1 Lucas Gass (lukeg) 2024-01-09 21:48:30 UTC

To recreate:

1. Have multiple additional content items ( news/HTML customization/Pages )
2. On one of the pages ( news/HTML customization/Pages ) select more than one item and try to delete using the 'Delete selected' button 
3. You are redirected but nothing happens.

Comment 2 Lucas Gass (lukeg) 2024-01-09 21:50:48 UTC

Created attachment 160726 [details] [review]
Bug 35752: Pass CSRF token to del_form

To test:

1. Have multiple additional content items ( news/HTML customization/Pages )
2. On one of the pages ( news/HTML customization/Pages ) select more than one item and try to delete using the 'Delete selected' button
3. You are redirected but nothing happens.
4. APPLY PATCH
5. Try again, this time you should be able to successfully delete additional-contents.

Comment 3 Jonathan Druart 2024-01-11 07:57:44 UTC

Note: With bug 34862 we get the CSRF error message.

Comment 4 Jonathan Druart 2024-01-11 07:58:54 UTC

Created attachment 160799 [details] [review]
Bug 35752: Pass CSRF token to del_form

To test:

1. Have multiple additional content items ( news/HTML customization/Pages )
2. On one of the pages ( news/HTML customization/Pages ) select more than one item and try to delete using the 'Delete selected' button
3. You are redirected but nothing happens.
4. APPLY PATCH
5. Try again, this time you should be able to successfully delete additional-contents.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Comment 5 Victor Grousset/tuxayo 2024-01-18 23:18:06 UTC

Created attachment 161163 [details] [review]
Bug 35752: Pass CSRF token to del_form

To test:

1. Have multiple additional content items ( news/HTML customization/Pages )
2. On one of the pages ( news/HTML customization/Pages ) select more than one item and try to delete using the 'Delete selected' button
3. You are redirected but nothing happens.
4. APPLY PATCH
5. Try again, this time you should be able to successfully delete additional-contents.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

Comment 6 Victor Grousset/tuxayo 2024-01-18 23:18:29 UTC

Works, makes sense, QA script happy, code looks good, passing QA :)

Comment 7 Katrin Fischer 2024-01-26 14:18:06 UTC

Pushed for 24.05!

Well done everyone, thank you!

Comment 8 Fridolin Somers 2024-01-31 13:30:14 UTC

Pushed to 23.11.x for 23.11.03