Summary: | Remove Koha::Template::Plugin::Biblio::CanBook | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | RESOLVED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, fridolin.somers, martin.renvoize, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
URL: | https://github.com/PTFS-Europe/koha/tree/bug_35787 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00
|
|
Circulation function: | |||
Bug Depends on: | 29002, 35782 | ||
Bug Blocks: | 35788 | ||
Attachments: |
Bug 35787: Remove Koha::Template::Plugin::Biblio::CanBook
Bug 35787: Remove Koha::Template::Plugin::Biblio::CanBook Bug 35787: Add unit test for filter_by_bookable |
Description
Jonathan Druart
2024-01-12 13:03:23 UTC
Created attachment 160960 [details] [review] Bug 35787: Remove Koha::Template::Plugin::Biblio::CanBook We can replace it with biblio.items.filter_by_bookable, no need to have this TT method. Additionally there was no test for it. Test plan: Make sure the Bookings tab on the left of the biblio detail page is displayed when needed. Note that there is also a "Place booking" button that should appear in the toolbar. Created attachment 161038 [details] [review] Bug 35787: Remove Koha::Template::Plugin::Biblio::CanBook We can replace it with biblio.items.filter_by_bookable, no need to have this TT method. Additionally there was no test for it. Test plan: Make sure the Bookings tab on the left of the biblio detail page is displayed when needed. Note that there is also a "Place booking" button that should appear in the toolbar. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Works as expected, QA script happy. QA question: You considered this TT method too new for a dbrev? I'd agree, just mentioning in case it was an unintended miss. (In reply to Tomás Cohen Arazi from comment #3) > Works as expected, QA script happy. > > QA question: You considered this TT method too new for a dbrev? I'd agree, > just mentioning in case it was an unintended miss. Yes, on purpose. I don't think we need one. Agreed on the too new to warrant the db rev.. but I will submit the unit tests for filter_by_bookable first thing tomorrow.. I have them on a branch Created attachment 161056 [details] [review] Bug 35787: Add unit test for filter_by_bookable Trivial test added for filter_by_bookable Branch pushed https://github.com/PTFS-Europe/koha/tree/bug_35787 Pushed for 24.05! Well done everyone, thank you! Enhancement not pushed to 23.11.x Architecture change, nothing to add/edit in the Koha manual. |