Summary: | Remove Koha::Template::Plugin::Biblio::ArticleRequestsActiveCount | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, david, fridolin.somers, martin.renvoize, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00
|
|
Circulation function: | |||
Bug Depends on: | 35788 | ||
Bug Blocks: | 35790 | ||
Attachments: |
Bug 35789: Remove Koha::Template::Plugin::Biblio::ArticleRequestsActiveCount
Bug 35789: Remove Koha::Template::Plugin::Biblio::ArticleRequestsActiveCount |
Description
Jonathan Druart
2024-01-12 13:33:29 UTC
Created attachment 160972 [details] [review] Bug 35789: Remove Koha::Template::Plugin::Biblio::ArticleRequestsActiveCount Can be replaced with biblio.article_requests.filter_by_current.count Test plan: Turn on article requests (syspref + circ rule) Request an article (detail page of a bib record) On the left you see "Article requests" tab with the number of current article requests. It should show the correct number (same as before this patch). The patch no longer applies - sha1 error: Bug 35789 - Remove Koha::Template::Plugin::Biblio::ArticleRequestsActiveCount 160972 - Bug 35789: Remove Koha::Template::Plugin::Biblio::ArticleRequestsActiveCount Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 35789: Remove Koha::Template::Plugin::Biblio::ArticleRequestsActiveCount error: sha1 information is lacking or useless (Koha/Template/Plugin/Biblio.pm). error: could not build fake ancestor Patch failed at 0001 Bug 35789: Remove Koha::Template::Plugin::Biblio::ArticleRequestsActiveCount (In reply to David Nind from comment #2) > The patch no longer applies - sha1 error: The dependencies were not correct. Fixed. Created attachment 161042 [details] [review] Bug 35789: Remove Koha::Template::Plugin::Biblio::ArticleRequestsActiveCount Can be replaced with biblio.article_requests.filter_by_current.count Test plan: Turn on article requests (syspref + circ rule) Request an article (detail page of a bib record) On the left you see "Article requests" tab with the number of current article requests. It should show the correct number (same as before this patch). Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Test plan follows correctly. I'd like to add that the AR count also displays on the detail view, not just the left tab. And it works. QA script happy, behavior correct, code is correct. Straight QA. We don't have the database update here that came with other similar patches, but maybe it's unlikely that this has been used in notices. Pushed for 24.05! Well done everyone, thank you! Not backported to 23.11.x Architecture change, nothing to add/edit in the Koha manual. |