Bug 35793

Summary: Remove Koha::Template::Plugin::Cache
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: Pushed to main --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: tomascohen
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00
Bug Depends on: 7387    
Bug Blocks: 35781    
Attachments: Bug 35793: Remove Koha::Template::Plugin::Cache
Bug 35793: Remove Koha::Template::Plugin::Cache
Bug 35793: Remove tests of removed class

Description Jonathan Druart 2024-01-12 14:39:31 UTC
Introduced in 2011 by bug 7387 but has never been used.
Comment 1 Jonathan Druart 2024-01-12 14:41:47 UTC
Created attachment 160971 [details] [review]
Bug 35793: Remove Koha::Template::Plugin::Cache

Introduced in 2011 by bug 7387 but has never been used.
Removing it.

Test plan:
 git grep Cache **/*.tt **/*.inc
should not return relevant results.
Comment 2 Tomás Cohen Arazi 2024-01-15 18:11:14 UTC
Created attachment 161049 [details] [review]
Bug 35793: Remove Koha::Template::Plugin::Cache

Introduced in 2011 by bug 7387 but has never been used.
Removing it.

Test plan:
 git grep Cache **/*.tt **/*.inc
should not return relevant results.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Tomás Cohen Arazi 2024-01-15 18:12:46 UTC
Trivial patch. Straight QA
Comment 4 Katrin Fischer 2024-03-22 11:28:29 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Katrin Fischer 2024-03-22 12:51:28 UTC
We have a failing test - investigating:
 t_Koha_Template_Plugin_Cache_t.use Koha::Template::Plugin::Cache; (2166)
Comment 6 Katrin Fischer 2024-03-22 12:53:02 UTC
I'll push a follow-up removing the now obsolete test file. Sorry I didn't spot that right away.
Comment 7 Tomás Cohen Arazi 2024-03-22 13:10:17 UTC
Created attachment 163703 [details] [review]
Bug 35793: Remove tests of removed class

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>