Bug 35831

Summary:	Move UpdateItemLocationOnCheckout to Checkout policy section
Product:	Koha	Reporter:	Caroline Cyr La Rose <caroline.cyr-la-rose>
Component:	System Administration	Assignee:	Caroline Cyr La Rose <caroline.cyr-la-rose>
Status:	RESOLVED FIXED	QA Contact:	Martin Renvoize (ashimema) <martin.renvoize>
Severity:	trivial
Priority:	P5 - low	CC:	aude.charillon, fridolin.somers, gmcharlt, lucas, martin.renvoize
Version:	unspecified
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	String patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	24.05.00,23.11.03
Circulation function:
Attachments:	Bug 35831: Move UpdateItemLocationOnCheckout to Checkout policy section Bug 35831: Move UpdateItemLocationOnCheckout to Checkout policy section Bug 35831: Move UpdateItemLocationOnCheckout to Checkout policy section

Description Caroline Cyr La Rose 2024-01-17 21:33:17 UTC

The UpdateItemLocationOnCheckout system preference introduced in bug 21159 has been put under Circulation > Checkin policy. As this affect items on checkout, I think it should go under Circulation > Checkout policy.

Comment 1 Caroline Cyr La Rose 2024-01-17 21:42:31 UTC

Created attachment 161120 [details] [review]
Bug 35831: Move UpdateItemLocationOnCheckout to Checkout policy section

This patch moves the UpdateItemLocationOnCheckout system preference from
the Checkin policy section of the circulation preferences to the
Checkout policy section.

To test:
1. Apply patch
2. Go to Administration > System preferences > Circulation
3. Check that UpdateItemLocationOnCheckout is under Checkout policy

The text should be the same as before, and the feature should not have changed.

Comment 2 Aude Charillon 2024-01-19 11:56:48 UTC

Works as described: the UpdateItemLocationOnCheckout system preference disappears from the Checkin policy section and correctly appears in the Checkout policy one instead.

Comment 3 PTFS Europe Sandboxes 2024-01-19 11:57:46 UTC

Created attachment 161207 [details] [review]
Bug 35831: Move UpdateItemLocationOnCheckout to Checkout policy section

This patch moves the UpdateItemLocationOnCheckout system preference from
the Checkin policy section of the circulation preferences to the
Checkout policy section.

To test:
1. Apply patch
2. Go to Administration > System preferences > Circulation
3. Check that UpdateItemLocationOnCheckout is under Checkout policy

The text should be the same as before, and the feature should not have changed.

Signed-off-by: Aude <aude.charillon@ptfs-europe.com>

Comment 4 Martin Renvoize (ashimema) 2024-01-23 17:16:09 UTC

Created attachment 161310 [details] [review]
Bug 35831: Move UpdateItemLocationOnCheckout to Checkout policy section

This patch moves the UpdateItemLocationOnCheckout system preference from
the Checkin policy section of the circulation preferences to the
Checkout policy section.

To test:
1. Apply patch
2. Go to Administration > System preferences > Circulation
3. Check that UpdateItemLocationOnCheckout is under Checkout policy

The text should be the same as before, and the feature should not have changed.

Signed-off-by: Aude <aude.charillon@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 5 Katrin Fischer 2024-01-26 14:18:18 UTC

Pushed for 24.05!

Well done everyone, thank you!

Comment 6 Fridolin Somers 2024-01-31 14:02:02 UTC

Pushed to 23.11.x for 23.11.03

Comment 7 Lucas Gass (lukeg) 2024-02-09 20:38:00 UTC

Doesn't apply clean to 23.05.x, no backport.