Bug 35952

Summary: Removed unnecessary line in opac-blocked.pl
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: OPACAssignee: Lucas Gass (lukeg) <lucas>
Status: RESOLVED FIXED QA Contact: Julian Maurice <julian.maurice>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, julian.maurice
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.04,23.05.10
Circulation function:
Bug Depends on: 34894    
Bug Blocks:    
Attachments: Bug 35952: Remove unnecessary line for OpacSuppressionMessage
Bug 35952: Remove unnecessary line for OpacSuppressionMessage
Bug 35952: Remove unnecessary line for OpacSuppressionMessage

Description Lucas Gass (lukeg) 2024-01-30 20:36:34 UTC
-$template->param ( OpacSuppressionMessage => C4::Context->preference('OpacSuppressionMessage'));

This line is useless now that OpacSuppressionMessage comes from additional_contents, not a sys pref.
Comment 1 Lucas Gass (lukeg) 2024-01-30 20:40:59 UTC
Created attachment 161662 [details] [review]
Bug 35952: Remove unnecessary line for OpacSuppressionMessage

To test:
1. Apply patch and restart all
2. Add an additional contetn entry for `OpacSuppressionMessage`, make sure it has a publication date in the past.
3. Make sure  OpacSuppression is set to 'hide'.
4. Suppress a record in the OPAC, ( 942$n )
5. Visit the detail page for that record and make sure you OpacSuppressionMessage customization displays.
Comment 2 Owen Leonard 2024-01-31 13:02:01 UTC
Created attachment 161681 [details] [review]
Bug 35952: Remove unnecessary line for OpacSuppressionMessage

To test:
1. Apply patch and restart all
2. Add an additional contetn entry for `OpacSuppressionMessage`, make
   sure it has a publication date in the past.
3. Make sure  OpacSuppression is set to 'hide'.
4. Suppress a record in the OPAC, ( 942$n )
5. Visit the detail page for that record and make sure you
   OpacSuppressionMessage customization displays.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Julian Maurice 2024-02-16 09:59:28 UTC
Created attachment 162237 [details] [review]
Bug 35952: Remove unnecessary line for OpacSuppressionMessage

To test:
1. Apply patch and restart all
2. Add an additional contetn entry for `OpacSuppressionMessage`, make
   sure it has a publication date in the past.
3. Make sure  OpacSuppression is set to 'hide'.
4. Suppress a record in the OPAC, ( 942$n )
5. Visit the detail page for that record and make sure you
   OpacSuppressionMessage customization displays.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 4 Katrin Fischer 2024-03-07 14:04:11 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-03-11 09:41:44 UTC
Bug 34894 moved preference to HTML customization
Comment 6 Fridolin Somers 2024-03-11 09:42:12 UTC
Pushed to 23.11.x for 23.11.04
Comment 7 Lucas Gass (lukeg) 2024-03-19 15:28:14 UTC
Backported to 23.05.x for upcoming 23.05.10