| Summary: | Add --status to koha-plack | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Magnus Enger <magnus> |
| Component: | Command-line Utilities | Assignee: | Magnus Enger <magnus> |
| Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, lucas, martin.renvoize, robin, tadeusz |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.06
|
|
| Circulation function: | |||
| Attachments: |
Bug 35954: Add --status to koha-plack
Bug 35954: Add --status to koha-plack Bug 35954: Add --status to koha-plack Bug 35954: Add --status to koha-plack |
||
|
Description
Magnus Enger
2024-01-31 07:29:59 UTC
Created attachment 161740 [details] [review] Bug 35954: Add --status to koha-plack This adds a --status switch to the koha-plack command. To test on ktd: - Copy the script to /usr/sbin, so you run the modified script, and not the one installed by Koha: $ sudo cp debian/scripts/koha-plack /usr/sbin/ - Stop and start Plack for kohadev like so: $ sudo koha-plack --stop kohadev $ sudo koha-plack --start kohadev And make sure this reports the correct status, both when Plack is running and when it is not running: $ sudo koha-plack --status kohadev - Make sure --status is mentioned here: $ sudo koha-plack --help - See https://wiki.koha-community.org/wiki/Testing_man_pages for details on how to check the manual page for the command Created attachment 161741 [details] [review] Bug 35954: Add --status to koha-plack This adds a --status switch to the koha-plack command. To test on ktd: - Copy the script to /usr/sbin, so you run the modified script, and not the one installed by Koha: $ sudo cp debian/scripts/koha-plack /usr/sbin/ - Stop and start Plack for kohadev like so: $ sudo koha-plack --stop kohadev $ sudo koha-plack --start kohadev And make sure this reports the correct status, both when Plack is running and when it is not running: $ sudo koha-plack --status kohadev - Make sure --status is mentioned here: $ sudo koha-plack --help - See https://wiki.koha-community.org/wiki/Testing_man_pages for details on how to check the manual page for the command Created attachment 166095 [details] [review] Bug 35954: Add --status to koha-plack This adds a --status switch to the koha-plack command. To test on ktd: - Copy the script to /usr/sbin, so you run the modified script, and not the one installed by Koha: $ sudo cp debian/scripts/koha-plack /usr/sbin/ - Stop and start Plack for kohadev like so: $ sudo koha-plack --stop kohadev $ sudo koha-plack --start kohadev And make sure this reports the correct status, both when Plack is running and when it is not running: $ sudo koha-plack --status kohadev - Make sure --status is mentioned here: $ sudo koha-plack --help - See https://wiki.koha-community.org/wiki/Testing_man_pages for details on how to check the manual page for the command Signed-off-by: Tadeusz „tadzik” Sośnierz <tadeusz@sosnierz.com> We might want to fix the patch author: From: root <root@localhost> Created attachment 166106 [details] [review] Bug 35954: Add --status to koha-plack This adds a --status switch to the koha-plack command. To test on ktd: - Copy the script to /usr/sbin, so you run the modified script, and not the one installed by Koha: $ sudo cp debian/scripts/koha-plack /usr/sbin/ - Stop and start Plack for kohadev like so: $ sudo koha-plack --stop kohadev $ sudo koha-plack --start kohadev And make sure this reports the correct status, both when Plack is running and when it is not running: $ sudo koha-plack --status kohadev - Make sure --status is mentioned here: $ sudo koha-plack --help - See https://wiki.koha-community.org/wiki/Testing_man_pages for details on how to check the manual page for the command Signed-off-by: Tadeusz Sośnierz <tadeusz@sosnierz.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice addition, Passing QA (In reply to Katrin Fischer from comment #4) > We might want to fix the patch author: > From: root <root@localhost> Ooops, thanks for spotting and fixing that! :-) Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 Enhancement will not be backported to 23.05.x |