Bug 35961

Summary: Modal include missing for catalog concerns
Product: Koha Reporter: Martin Renvoize <martin.renvoize>
Component: Staff interfaceAssignee: Martin Renvoize <martin.renvoize>
Status: Pushed to main --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: david, gmcharlt, lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00
Bug Depends on: 31028    
Bug Blocks:    
Attachments: Bug 35961: Add missing includes
Bug 35961:i (follow-up) Pass along the borrowernumber
Bug 35961: Add missing includes
Bug 35961: (follow-up) Pass along the borrowernumber
Bug 35961: Add missing includes
Bug 35961: (follow-up) Pass along the borrowernumber

Description Martin Renvoize 2024-01-31 14:02:53 UTC
Jonathan Druart 2024-01-29 10:23:15 GMT
The modal only opens on opac-detail, however "Report a concern" is displayed on other pages (opac-isbd, opac-marc, etc.)
Comment 1 Martin Renvoize 2024-05-13 13:44:51 UTC
Created attachment 166637 [details] [review]
Bug 35961: Add missing includes

This patch adds the missing includes for the 'Catalog concerns' modal on
opac-MARCdetail and opac-ISBDdetail views.
Comment 2 Lucas Gass 2024-05-13 21:58:50 UTC
This doesn't work for me on the opac-MARC or opac-ISBD pages. When I hit submit on those pages I get "There was an error when submitting your concern, please contact a librarian."


If I review the source I see this:

<input type="hidden" name="reporter_id" id="concern_reporter" value="">

If I give that input a value of '51' I can successfully submit.
Comment 3 Lucas Gass 2024-05-13 22:17:49 UTC
Created attachment 166658 [details] [review]
Bug 35961:i (follow-up) Pass along the borrowernumber

To test:
1. APPLY PATCH
2. Turn on  OpacCatalogConcerns
3. Find a record and go to the OPAC detail page.
4. Click "Report a concern" in the right navigation menu
5. Make sure it works
6. Repeat the proces from MARC view and ISBD view pages
Comment 4 David Nind 2024-05-14 01:29:29 UTC
Created attachment 166663 [details] [review]
Bug 35961: Add missing includes

This patch adds the missing includes for the 'Catalog concerns' modal on
opac-MARCdetail and opac-ISBDdetail views.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2024-05-14 01:29:31 UTC
Created attachment 166664 [details] [review]
Bug 35961: (follow-up) Pass along the borrowernumber

To test:
1. APPLY PATCH
2. Turn on  OpacCatalogConcerns
3. Find a record and go to the OPAC detail page.
4. Click "Report a concern" in the right navigation menu
5. Make sure it works
6. Repeat the proces from MARC view and ISBD view pages

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2024-05-14 01:32:02 UTC
Works as expected.

I did have some odd behavour when logged out and then logging in to submit the concern.

I was getting an error "There was an error when submitting your concern, please contact a librarian." when submitting on the ISBD view or MARC view, but not consistently.

Browser console error is:

"Failed to load resource: the server responded with a status of 400 (Bad Request) :8080/api/v1/public/tickets:1"

However, I think this is related to not having hostnames configured correctly for my desktop and KTD.
Comment 7 Nick Clemens (kidclamp) 2024-05-15 12:38:14 UTC
Created attachment 166774 [details] [review]
Bug 35961: Add missing includes

This patch adds the missing includes for the 'Catalog concerns' modal on
opac-MARCdetail and opac-ISBDdetail views.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 8 Nick Clemens (kidclamp) 2024-05-15 12:38:16 UTC
Created attachment 166775 [details] [review]
Bug 35961: (follow-up) Pass along the borrowernumber

To test:
1. APPLY PATCH
2. Turn on  OpacCatalogConcerns
3. Find a record and go to the OPAC detail page.
4. Click "Report a concern" in the right navigation menu
5. Make sure it works
6. Repeat the proces from MARC view and ISBD view pages

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 9 Katrin Fischer 2024-05-17 08:37:23 UTC
Pushed for 24.05!

Well done everyone, thank you!