| Summary: | Dead code in admin/clone-rules | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> | 
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> | 
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> | 
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers | 
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | 
       24.05.00 
 | 
        
        Circulation function: | |
| Bug Depends on: | 18936 | ||
| Bug Blocks: | 34478 | ||
| Attachments: | 
              Bug 36017: Remove dead code in admin/clone-rules
               Bug 36017: Remove dead code in admin/clone-rules Bug 36017: Remove dead code in admin/clone-rules  | 
      ||
| 
 
        
          Description
        
        
          Jonathan Druart
        
        
        
        
          2024-02-07 14:40:41 UTC
        
       
    Created attachment 161809 [details] [review] Bug 36017: Remove dead code in admin/clone-rules Since commit 61628c97c245e72c750b61d9df6fa9b9100f3093 Bug 18936: (follow-up) Add cloning of circulation rules back to Koha There are some dead code in admin/clone-rules. "result" is always passed to the template. Test plan: Confirm the above and that cloning rules from the circ rules page still works correctly. Created attachment 161818 [details] [review] Bug 36017: Remove dead code in admin/clone-rules Since commit 61628c97c245e72c750b61d9df6fa9b9100f3093 Bug 18936: (follow-up) Add cloning of circulation rules back to Koha There are some dead code in admin/clone-rules. "result" is always passed to the template. Test plan: Confirm the above and that cloning rules from the circ rules page still works correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 161950 [details] [review] Bug 36017: Remove dead code in admin/clone-rules Since commit 61628c97c245e72c750b61d9df6fa9b9100f3093 Bug 18936: (follow-up) Add cloning of circulation rules back to Koha There are some dead code in admin/clone-rules. "result" is always passed to the template. Test plan: Confirm the above and that cloning rules from the circ rules page still works correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 24.05.00. Enhancement not pushed to 23.11.x  |