|
Description
David Gustafsson
2024-02-07 16:08:31 UTC
Created attachment 161819 [details] [review] Bug 36022: Add default recipient SMS number country code Add SMSSendDefaultCountryCode syspref to prepend country code to non international SMS numbers. To test: TODO Will attach a test plan once I've figured out how to test, since it's not currently possible to inspect the parameters of send_sms it's not obvious how to do this. Created attachment 161820 [details] [review] Bug 36022: Add default recipient SMS number country code Add SMSSendDefaultCountryCode syspref to prepend country code to non international SMS numbers. To test: TODO Created attachment 161946 [details] [review] Bug 36022: Add default recipient SMS number country code Add SMSSendDefaultCountryCode syspref to prepend country code to non international SMS numbers. To test: 1) Apply patch and run updatedatabase.pl 2) Verify that SMSSendDefaultCountryCode syspref can be set staff interface system preferences 3) Verify all tests pass in t/SMS.t Sponsored-by: Gothenburg University Library Created attachment 161947 [details] [review] Bug 36022: Add default recipient SMS number country code Add SMSSendDefaultCountryCode syspref to prepend country code to non international SMS numbers. To test: 1) Apply patch and run updatedatabase.pl 2) Verify that SMSSendDefaultCountryCode syspref can be set in staff interface system preferences 3) Verify all tests pass in t/SMS.t Sponsored-by: Gothenburg University Library Created attachment 161948 [details] [review] Bug 36022: Add default recipient SMS number country code Add SMSSendDefaultCountryCode syspref to prepend country code to non international SMS numbers. To test: 1) Apply patch and run updatedatabase.pl 2) Verify that SMSSendDefaultCountryCode syspref can be set in staff interface system preferences 3) Verify all tests pass in t/SMS.t Sponsored-by: Gothenburg University Library Added tests, should now be ready for signoff. Created attachment 161949 [details] [review] Bug 36022: Add default recipient SMS number country code Add SMSSendDefaultCountryCode syspref to prepend country code to non international SMS numbers. To test: 1) Apply patch and run updatedatabase.pl 2) Verify that SMSSendDefaultCountryCode syspref can be set in staff interface system preferences 3) Verify all tests pass in t/SMS.t Sponsored-by: Gothenburg University Library Created attachment 178177 [details] [review] Bug 36022: Add default recipient SMS number country code Add SMSSendDefaultCountryCode syspref to prepend country code to non international SMS numbers. To test: 1) Apply patch and run updatedatabase.pl 2) Verify that SMSSendDefaultCountryCode syspref can be set in staff interface system preferences 3) Verify all tests pass in t/SMS.t Sponsored-by: Gothenburg University Library Rebased against main. Please rebase again! |