Bug 36031

Summary: Get rid of (outdated) misc/bin/set-selinux-labels.sh
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: Architecture, internals, and plumbingAssignee: Marcel de Rooy <m.de.rooy>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: caroline.cyr-la-rose, fridolin.somers, julian.maurice
Version: MainKeywords: release-notes-needed
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00
Circulation function:
Attachments: Bug 36031: Remove obsoleted script
Bug 36031: Remove obsoleted script

Description Marcel de Rooy 2024-02-08 08:38:54 UTC
This script is probably not used. And it is outdated anyway. I propose to remove it.
Comment 1 Marcel de Rooy 2024-02-08 08:43:14 UTC
Created attachment 161877 [details] [review]
Bug 36031: Remove obsoleted script

Since it is not up to date, we should remove it.

No test plan here.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2024-02-08 08:43:55 UTC
Moving to SO.
Comment 3 Julian Maurice 2024-02-23 11:18:57 UTC
Can you add in the commit message a small explanation about what makes the script outdated ? It might by obvious to SELinux users, but not to me :)
Comment 4 Marcel de Rooy 2024-02-27 12:34:48 UTC
(In reply to Julian Maurice from comment #3)
> Can you add in the commit message a small explanation about what makes the
> script outdated ? It might by obvious to SELinux users, but not to me :)

Hi,
The folder structure changed. And as I did not follow SELinux in recent years either, this also needs digging into SELinux to update that side as well.
In other words, remove this until someone finds time do it. But dont let it here in its current outdated state.
Comment 5 Nick Clemens (kidclamp) 2024-04-01 16:57:54 UTC
Created attachment 164213 [details] [review]
Bug 36031: Remove obsoleted script

Since it is not up to date, we should remove it.
The folder structure changed and this would need digging into SELinux to update that side as well.
In other words, remove this until someone finds time do it. But dont let it here in its current outdated state.

No test plan here.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Katrin Fischer 2024-04-05 09:52:34 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-05-23 09:49:30 UTC
I prefer not to backport to 23.11.x
Comment 8 Caroline Cyr La Rose 2024-07-04 19:31:00 UTC
Architecture change, nothing to add/edit in the Koha manual.