Bug 36082

Summary: OPACResultsSideBar not working with library specific message
Product: Koha Reporter: Kelly McElligott <kelly>
Component: ToolsAssignee: Lucas Gass (lukeg) <lucas>
Status: RESOLVED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, kelly, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06
Circulation function:
Bug Depends on: 34869    
Bug Blocks:    
Attachments: Bug 36082: Set branchcode correctly in opac-facets.inc
Bug 36082: Set branchcode correctly in opac-facets.inc
Bug 36082: Set branchcode correctly in opac-facets.inc

Description Kelly McElligott 2024-02-13 13:53:18 UTC
With the introduction in 23.11 moving the system preference, OPACResultsSideBar, to the Tools> HTML customization, it does not appear to be working with a library specific message.  When creating a OPACresultsidebar to 'all libraries', this message does appear.
Steps to reproduce:
1. Tools> HTML Customization
2. Choose OPACresultssidebar
3. Create an entry specific to a library. 
4. Also try to add this same entry into a translation tab, if installed.
5. Go to the OPAC
6. Login as a patron of that library that the specific OPACresultsidebar is assigned to
7. Search the catalog, and look below the facets,where the OPACresultssidebar would appear.
8. No text.

Attempt to do this test plan, but creating a 'all libraries' entry will appear in the OPAC as expected.
Comment 1 Lucas Gass (lukeg) 2024-02-29 22:23:44 UTC
Confirmed on current master
Comment 2 Lucas Gass (lukeg) 2024-02-29 22:34:20 UTC
Created attachment 162628 [details] [review]
Bug 36082: Set branchcode correctly in opac-facets.inc

1. Tools> HTML Customization
2. Choose OPACresultssidebar
3. Create an entry specific to a library.
4. Also try to add this same entry into a translation tab, if installed.
5. Go to the OPAC
6. Login as a patron of that library that the specific OPACresultsidebar is assigned to
7. Search the catalog, and look below the facets,where the OPACresultssidebar would appear.
8. No text.
9. APPLY PATCH
10. Try step 7 again.
11. TEXT!
Comment 3 David Nind 2024-03-10 02:19:19 UTC
Created attachment 163015 [details] [review]
Bug 36082: Set branchcode correctly in opac-facets.inc

1. Tools> HTML Customization
2. Choose OPACresultssidebar
3. Create an entry specific to a library.
4. Also try to add this same entry into a translation tab, if installed.
5. Go to the OPAC
6. Login as a patron of that library that the specific OPACresultsidebar is assigned to
7. Search the catalog, and look below the facets,where the OPACresultssidebar would appear.
8. No text.
9. APPLY PATCH
10. Try step 7 again.
11. TEXT!

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Marcel de Rooy 2024-04-05 09:35:11 UTC
Created attachment 164462 [details] [review]
Bug 36082: Set branchcode correctly in opac-facets.inc

1. Tools> HTML Customization
2. Choose OPACresultssidebar
3. Create an entry specific to a library.
4. Also try to add this same entry into a translation tab, if installed.
5. Go to the OPAC
6. Login as a patron of that library that the specific OPACresultsidebar is assigned to
7. Search the catalog, and look below the facets,where the OPACresultssidebar would appear.
8. No text.
9. APPLY PATCH
10. Try step 7 again.
11. TEXT!

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Katrin Fischer 2024-04-05 15:40:45 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-05-23 12:01:38 UTC
Pushed to 23.11.x for 23.11.06
Comment 7 Lucas Gass (lukeg) 2024-05-28 17:37:51 UTC
Not needed in 23.05.x, no backport.