Summary: | Circulation home page styling does not match Cataloging home page styling | ||
---|---|---|---|
Product: | Koha | Reporter: | Pedro Amorim <pedro.amorim> |
Component: | Staff interface | Assignee: | Pedro Amorim <pedro.amorim> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, fridolin.somers, gmcharlt, lucas, martin.renvoize, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the styling of the circulation home page for the staff interface. It is now consistent with the cataloging home page, and includes wider side margins.
|
Version(s) released in: |
24.05.00,23.11.04
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 36164 | ||
Attachments: |
Bug 36150: Update circulation-home.tt layout
Bug 36150: Update circulation-home.tt layout Bug 36150: Update circulation-home.tt layout |
Description
Pedro Amorim
2024-02-22 12:08:53 UTC
Created attachment 162331 [details] [review] Bug 36150: Update circulation-home.tt layout Test plan: Compare both pages: <staff_url>/cgi-bin/koha/cataloguing/cataloging-home.pl <staff_url>/cgi-bin/koha/circ/circulation-home.pl Apply patch Compare both pages again git show -w <patch_hash>: @@ -23,9 +23,11 @@ [% END #/ WRAPPER sub-header.inc %] <div class="main container-fluid"> + <div class="row"> + <div class="col-md-10 col-md-offset-1 col-lg-8 col-lg-offset-2"> + [% INCLUDE 'messages.inc' %] <h1>Circulation</h1> - [% INCLUDE 'messages.inc' %] <div class="row"> @@ -180,5 +182,7 @@ </div> </div> </div> + </div> + </div> Created attachment 162399 [details] [review] Bug 36150: Update circulation-home.tt layout Test plan: Compare both pages: <staff_url>/cgi-bin/koha/cataloguing/cataloging-home.pl <staff_url>/cgi-bin/koha/circ/circulation-home.pl Apply patch Compare both pages again Signed-off-by: David Nind <david@davidnind.com> This is much nicer, and more consistent! Created attachment 162427 [details] [review] Bug 36150: Update circulation-home.tt layout Test plan: Compare both pages: <staff_url>/cgi-bin/koha/cataloguing/cataloging-home.pl <staff_url>/cgi-bin/koha/circ/circulation-home.pl Apply patch Compare both pages again Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Great consistency improvement, thanks Pedro. Passing QA Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.04 Does not apply cleanly to 23.05.x, no backport. |